After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757314 - Remove return value in terminal_screen_check_extra
Remove return value in terminal_screen_check_extra
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-29 15:23 UTC by Ting-Wei Lan
Modified: 2015-10-30 07:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Remove return value in terminal_screen_check_extra (633 bytes, patch)
2015-10-29 15:27 UTC, Ting-Wei Lan
none Details | Review

Description Ting-Wei Lan 2015-10-29 15:23:27 UTC
terminal_screen_check_extra is a void function, so it should not return a value.

terminal-screen.c:1976:3: error: void function 'terminal_screen_check_extra' should not return a value [-Wreturn-type]
  return NULL;
  ^      ~~~~
7 warnings and 1 error generated.
Comment 1 Ting-Wei Lan 2015-10-29 15:27:17 UTC
Created attachment 314411 [details] [review]
build: Remove return value in terminal_screen_check_extra
Comment 2 Egmont Koblinger 2015-10-30 07:07:20 UTC
Hmmm, no clue why my gcc didn't even warn me :)
Thanks, submitted.