After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757283 - Inaccurate message in case of missing gstreamer development package.
Inaccurate message in case of missing gstreamer development package.
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 750547
 
 
Reported: 2015-10-29 06:10 UTC by Pavel Bludov
Modified: 2015-11-04 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
configure.ac: don't use an undefined variable (1.19 KB, patch)
2015-11-04 14:41 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Pavel Bludov 2015-10-29 06:10:21 UTC
If the environment lacks a gst-dev package, this error will be reported to the user:
"gstreamer- was not found"

These lines in configure.am are in charge:

if test -z "$GST_PKG_VERSION"; then
    AC_MSG_ERROR([gstreamer-$GST_PKG_VERSION was not found])
fi

I think the warning should be
    AC_MSG_ERROR([gstreamer-1.0 was not found])
since GST_PKG_VERSION must be nothing to trigger this message.

It all comes from this commit by Ceyusa:
autotools: remove gstreamer-0.10 support 0311c7c8af6bcab9f5ea38c39d80556ef9e34803.
Comment 1 Víctor Manuel Jáquez Leal 2015-11-04 14:41:46 UTC
Created attachment 314828 [details] [review]
configure.ac: don't use an undefined variable

If the environment lacks of gstreamer development packages, this error will
be reported to the user: "gstreamer- was not found"

This is because we are using an undefined variable in the printed message. The
fix simple changes the variable for the hard-coded string "1.0".

Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Comment 2 Víctor Manuel Jáquez Leal 2015-11-04 14:45:15 UTC
Attachment 314828 [details] pushed as 486ad0b - configure.ac: don't use an undefined variable