After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757193 - multiqueue: Handle negative DTS
multiqueue: Handle negative DTS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-27 15:42 UTC by Edward Hervey
Modified: 2015-12-02 15:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Edward Hervey 2015-10-27 15:42:16 UTC 
+++ This bug was initially created as a clone of Bug #756507 +++

Now that core has the notion of negative DTS, we should adjust the position/level calculation to take those into account.
Comment 1 Nicolas Dufresne (ndufresne) 2015-10-27 17:42:46 UTC 
I doubt this shall be considered a feature, but a bug. Edward fix would work completly in 1.4, and present a bug in 1.6 for the first group of buffers. First step first, we should implement a unit test to demonstrate.
Comment 2 Edward Hervey 2015-11-30 08:45:02 UTC 
Gave it a quick glance this morning. It won't be as trivial as expected, because like quite a few elements, it uses segment.position to store the current (buffer time) position ... which is a guint64. To make use of the new features, it would require yet-another field to store the signed position for each segment.
Comment 3 Edward Hervey 2015-12-02 15:08:23 UTC 
commit 4d96e5b8341732326243777a3667956fb4c9daf0
Author: Edward Hervey <edward@centricular.com>
Date:   Mon Nov 30 17:09:43 2015 +0100

    multiqueue: Use signed clock values for running time calculation
    
    This improves the accuracy of queue levels and when to push buffers
    for buffers falling outside of the segment
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757193