After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757190 - progress-info: Don't use g_object_unref to destroy a GTimer
progress-info: Don't use g_object_unref to destroy a GTimer
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.18.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-27 14:26 UTC by Debarshi Ray
Modified: 2015-10-27 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
progress-info: Use the proper destroy method (1.04 KB, patch)
2015-10-27 14:27 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2015-10-27 14:26:11 UTC
GTimer is not a GObject. Hence we can't use g_object_unref to destroy it. Instead, we should use g_timer_destroy.

Backtrace:

(gdb) bt
  • #0 g_type_check_instance_is_fundamentally_a
  • #1 g_object_unref
  • #2 nautilus_progress_info_finalize
    at nautilus-progress-info.c line 95
  • #3 g_object_unref
  • #4 g_list_foreach
  • #5 g_list_free_full
  • #6 nautilus_progress_info_manager_finalize
    at nautilus-progress-info-manager.c line 50
  • #7 g_object_unref
  • #8 nautilus_progress_persistence_handler_dispose
    at nautilus-progress-persistence-handler.c line 346
  • #9 g_object_unref
  • #10 nautilus_application_finalize
    at nautilus-application.c line 636
  • #11 g_object_unref
  • #12 main
    at nautilus-main.c line 106
  • #1 g_object_unref
    from /lib64/libgobject-2.0.so.0
  • #2 nautilus_progress_info_finalize
    at nautilus-progress-info.c line 95
$1 = (GTimer *) 0x0
(gdb)
Comment 1 Debarshi Ray 2015-10-27 14:27:24 UTC
Created attachment 314228 [details] [review]
progress-info: Use the proper destroy method
Comment 2 Carlos Soriano 2015-10-27 14:31:03 UTC
Review of attachment 314228 [details] [review]:

right, thanks!
master and gnome-3-18 please
Comment 3 Debarshi Ray 2015-10-27 14:38:44 UTC
Thanks for taking a look. Pushed.