After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757170 - Modifies task twice
Modifies task twice
Status: RESOLVED FIXED
Product: gnome-todo
Classification: Other
Component: General
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-27 06:56 UTC by Milan Crha
Modified: 2015-10-27 17:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
edit-pane: don't send ::edit-finished signal needlessly (1.14 KB, patch)
2015-10-27 17:19 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Milan Crha 2015-10-27 06:56:42 UTC 
While I was investigating the cause of the crash from bug #757169, I noticed that gnome-todo calls e_cal_client_modify() twice when saving the changes. At least the backtrace and my debugging shows that. The gnome-todo should call the "modify" only once, not twice, for one change.

Steps:
a) edit an existing task in a Google calendar
b) change Due date and Priority
c) click the "x" button of the task details to save the changes

The associated evolution-calendar-factory-subprocess shows that the modify is called twice "at the same time".
Comment 1 Georges Basile Stavracas Neto 2015-10-27 17:19:41 UTC 
Created attachment 314250 [details] [review]
edit-pane: don't send ::edit-finished signal needlessly

The fix for the double save.
Comment 2 Georges Basile Stavracas Neto 2015-10-27 17:20:51 UTC 
Attachment 314250 [details] pushed as 2ead42d - edit-pane: don't send ::edit-finished signal needlessly