GNOME Bugzilla – Bug 757164
Update theme for GTK+ 3.19
Last modified: 2016-01-13 04:28:35 UTC
This does NOT fix the SCSS file; I need Lapo to help with that, since I can't figure out how to compile the SCSS. (Also note we have unused SCSS for the downloads bar that was removed.)
Created attachment 314176 [details] [review] Update for removal of GTK_STYLE_CLASS_ENTRY
CC: Lapo (help please :) Note: Don't push this until the version bump to GTK+ 3.19.1 occurs
Michael, GTK+ CSS is pretty much in flux still, let's wait for the the button styleclass to change as we'll before looking into this, OK?
Created attachment 317700 [details] [review] Regenerate CSS with current GTK+ master
Created attachment 317701 [details] [review] Remove theme for old download box It's gone
Created attachment 317702 [details] [review] Update for removal of GTK_STYLE_CLASS_ENTRY
Created attachment 317703 [details] [review] Update the theme for CSS nodes button and entry are now CSS names, not style classes. I probably missed something, or screwed this up, so a review would be awesome (Lapo ;)
By the way, see https://bugs.webkit.org/show_bug.cgi?id=150550 for the corresponding WebKit bug, if you want a usable web browser or want to help me figure out how to draw progress bars again. The patch in that bug fixes stuff inside the web view (like Bugzilla forms and selections and the scrollbar).
Arnaud, I think you're probably qualified to review this too? You certainly understand CSS better than I do....
Review of attachment 317701 [details] [review]: Looks good
Attachment 317700 [details] pushed as 47b95d8 - Regenerate CSS with current GTK+ master Attachment 317701 [details] pushed as aa5f69f - Remove theme for old download box Attachment 317702 [details] pushed as f74683a - Update for removal of GTK_STYLE_CLASS_ENTRY Attachment 317703 [details] pushed as 19ff1cd - Update the theme for CSS nodes
Incognito mode title bar icon is broken: ** (epiphany:12502): WARNING **: CSS error in section beginning line 29 at offset 20: Not a valid image The line in question: background-image: -gtk-icontheme("user-not-tracked-symbolic"), headerbar_gradient(#cbd2d9);