After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757160 - rtspsrc: Wrong time conversion for "tcp-timeout"
rtspsrc: Wrong time conversion for "tcp-timeout"
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-26 23:00 UTC by Davy
Modified: 2015-10-27 23:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for valid time conversion (1.03 KB, patch)
2015-10-26 23:05 UTC, Davy 		none Details | Review
patch_2 (1.40 KB, patch)
2015-10-27 00:20 UTC, Davy 		reviewed Details | Review

Description Davy 2015-10-26 23:00:07 UTC 
In property description,
time unit of "tcp-timeout" is millisecond but gst_rtspsrc_set_tcp_timeout handle it as microsecond.
Comment 1 Davy 2015-10-26 23:05:46 UTC 
Created attachment 314169 [details] [review]
patch for valid time conversion

Attach patch
Comment 2 Davy 2015-10-27 00:20:17 UTC 
Created attachment 314173 [details] [review]
patch_2

oops..change default value also.
Comment 3 Sebastian Dröge (slomo) 2015-10-27 07:30:42 UTC 
Comment on attachment 314173 [details] [review]
patch_2

It might be better to do it the other way around, as people are likely already going to use it as if it was microseconds. So better keep the property as documented, and change the conversion only.

So that 20000000 stays the property default value, and really means 20s.
Comment 4 Davy 2015-10-27 23:44:58 UTC 
O god! what have I done??
The documentation is correct. it's already describe MICROs - When I saw it yesterday it was MILLIs!! 

so that this is not a bug but my eyes have some problem I need doctor.