After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757066 - Style checker should indicate no issues found if patch is clean
Style checker should indicate no issues found if patch is clean
Status: RESOLVED FIXED
Product: libgnome-games-support
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Sahil Sareen
libgames-scores maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-24 15:53 UTC by Sahil Sareen
Modified: 2015-10-25 07:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update style-checker (1.01 KB, patch)
2015-10-24 15:55 UTC, Sahil Sareen 		accepted-commit_now Details | Review

Description Sahil Sareen 2015-10-24 15:53:09 UTC 
Update code-style-checker for this case.
Comment 1 Sahil Sareen 2015-10-24 15:55:56 UTC 
Created attachment 314024 [details] [review]
Update style-checker
Comment 2 Michael Catanzaro 2015-10-25 02:06:26 UTC 
Review of attachment 314024 [details] [review]:

OK, though I think the ellipses (...) at the end of the sentences are unneeded; I would get rid of those.

::: style-checker
@@ +150,3 @@
     if nIssues != 0:
         if nIssues == 1:
+            print("Guideline checker found 1 issue...")

When writing single-digit numbers in a sentence, spell it out: "one."
Comment 3 Sahil Sareen 2015-10-25 07:10:15 UTC 
Thanks Michael,
Fixed and pushed.

To ssh://ssareen@git.gnome.org/git/libgames-support
   2ee8929..1274d06  master -> master