After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757043 - audioresample and other audio filters with history: Does not work properly with negative rates playback
audioresample and other audio filters with history: Does not work properly wi...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-24 07:52 UTC by Sebastian Dröge (slomo)
Modified: 2018-11-03 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2015-10-24 07:52:05 UTC
+++ This bug was initially created as a clone of Bug #757033 +++

Currently they handle reverse playback the same way as forwards playback. This will lead to discontinuities for every single buffer, as the first sample of the first buffer is going to be followed by the last sample of the next buffer. Filters with history will however handle it as if the last sample of the first buffer is followed by the first sample of the next one.

To solve this I propose we add a function to libgstaudio to reverse all samples in a buffer, and then have these filters set applied_rate to -1.0 and rate to -rate.
Comment 1 Sebastian Dröge (slomo) 2015-10-24 17:20:03 UTC
A patch for the same problem in scaletempo is in the linked bug. We'll have to do more or less the same for other elements. So need
- a function to reverse audio samples in a buffer
- adjust the segment, which basetransform does not really support right now (different input than output segment)
- adjust the timestamps of buffers

We can probably implement that in GstAudioFilter behind a flag, but audioresample and audioconvert are not using GstAudioFilter for example.
Comment 2 Luis de Bethencourt 2015-11-02 10:28:04 UTC
Looking into this.

Thanks Sebastian! :)
Comment 3 Sebastian Dröge (slomo) 2018-05-04 12:57:29 UTC
Reassigning to the default assignee as there does not seem to be any progress here
Comment 4 GStreamer system administrator 2018-11-03 11:42:46 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/236.