After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757026 - Add scroll source / axis stop information to scroll events
Add scroll source / axis stop information to scroll events
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
1.20.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-23 15:39 UTC by Carlos Garnacho
Modified: 2016-01-14 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
clutter-event: Add scroll source enum and axis scroll flags (5.28 KB, patch)
2015-10-23 15:39 UTC, Carlos Garnacho
committed Details | Review
evdev: Add scroll source/finish flags info to scroll events. (7.55 KB, patch)
2015-10-23 15:39 UTC, Carlos Garnacho
committed Details | Review

Description Carlos Garnacho 2015-10-23 15:39:08 UTC
On the evdev backend we can fetch already this information from libinput, on x11 we could infer some of this info, although I couldn't really tell for how long...

This may come useful in order to implement the (quite similar to libinput's) support for wayland: https://patchwork.freedesktop.org/patch/61985/

In the patches I'm attaching, I've added the fields to ClutterScrollEvent itself, according to pahole those still fit, although the struct is already on the limit, could it be preferred to put these into private data?
Comment 1 Carlos Garnacho 2015-10-23 15:39:49 UTC
Created attachment 313946 [details] [review]
clutter-event: Add scroll source enum and axis scroll flags

Those can be used to implement different scrolling behaviors.
The fields have been added to ClutterScrollEvent itself. According
to pahole, this makes the struct as big as ClutterButtonEvent and
ClutterTouchEvent, so already at the limit of the ClutterEvent
union.
Comment 2 Carlos Garnacho 2015-10-23 15:39:54 UTC
Created attachment 313947 [details] [review]
evdev: Add scroll source/finish flags info to scroll events.

Libinput tells us this much, so make use of it.
Comment 3 Emmanuele Bassi (:ebassi) 2015-10-24 10:31:31 UTC
Review of attachment 313946 [details] [review]:

Okay.
Comment 4 Emmanuele Bassi (:ebassi) 2015-10-24 10:32:33 UTC
Review of attachment 313947 [details] [review]:

Okay.
Comment 5 Carlos Garnacho 2016-01-14 18:16:31 UTC
Attachment 313946 [details] pushed as 89c1c1e - clutter-event: Add scroll source enum and axis scroll flags
Attachment 313947 [details] pushed as 307cb58 - evdev: Add scroll source/finish flags info to scroll events.