After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757005 - [review] bg/lldp-test-bgo757005: add test for LLDP listener
[review] bg/lldp-test-bgo757005: add test for LLDP listener
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-10-23 07:33 UTC by Beniamino Galvani
Modified: 2015-11-10 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Beniamino Galvani 2015-10-23 07:33:26 UTC 
Add a test for the LLDP listener to ensure that things don't
accidentally break when we import new code from systemd upstream.
Unfortunately root privileges are required in order to create a tap
interface on which frames can be received by the listener.

Please review.
Comment 1 Lubomir Rintel 2015-10-26 14:20:29 UTC 
LGTM
Comment 2 Thomas Haller 2015-11-03 14:02:40 UTC 
Is it not possible to create the tap device as non-root in a separate namespace?
You could reuse platforms common code (like the route-manager test does).

Otherwise, LGTM
Comment 3 Beniamino Galvani 2015-11-04 12:59:54 UTC 
(In reply to Thomas Haller from comment #2)
> Is it not possible to create the tap device as non-root in a separate
> namespace?
> You could reuse platforms common code (like the route-manager test does).

Cool, I didn't know this was possible. Pushed a fixup.
Comment 4 Jiri Klimes 2015-11-10 09:32:29 UTC 
Nitpicks:
missing space before "*/"
  0x01, 0x80, 0xc2, 0x00, 0x00, 0x03,     /* Destination MAC*/
  0x06, 0x02, 0x00, 0x78,                 /* TTL: 120 seconds*/

Otherwise LGTM.
Comment 5 Beniamino Galvani 2015-11-10 13:32:17 UTC 
(In reply to Jiri Klimes from comment #4)
> Nitpicks:
> missing space before "*/"

Fixed and merged:

http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=33d626b2958427b99ae7c92d712e2d15a73a05d5