After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756926 - kms-winsys: don't wait for a flip when page flipping fails
kms-winsys: don't wait for a flip when page flipping fails
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: EGL
unspecified
Other All
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
: 758112 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-10-21 20:00 UTC by Ray Strode [halfline]
Modified: 2017-02-20 08:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
kms-winsys: don't wait for a flip when page flipping fails (3.02 KB, patch)
2015-10-21 20:00 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2015-10-21 20:00:42 UTC 
If we get EACCES from drmPageFlip we're not going to get
a flip event and shouldn't wait for one.

This commit changes the EACCES path to silently ignore the
failed flip request and just clean up the fb.
Comment 1 Ray Strode [halfline] 2015-10-21 20:00:54 UTC 
Created attachment 313827 [details] [review]
kms-winsys: don't wait for a flip when page flipping fails
Comment 2 Ray Strode [halfline] 2015-10-21 20:07:31 UTC 
downstream bug:

https://bugzilla.redhat.com/show_bug.cgi?id=1272737
Comment 3 Emmanuele Bassi (:ebassi) 2015-10-23 14:17:33 UTC 
Review of attachment 313827 [details] [review]:

Looks good to me.
Comment 4 Ray Strode [halfline] 2015-10-23 14:51:12 UTC 
Attachment 313827 [details] pushed as b78052f - kms-winsys: don't wait for a flip when page flipping fails
Comment 5 Ray Strode [halfline] 2016-01-11 15:36:33 UTC 
*** Bug 758112 has been marked as a duplicate of this bug. ***
Comment 6 Olav Vitters 2017-02-19 16:41:45 UTC 
This was committed to master, but not to the 1.22 branch. Could this also be committed to the 1.22 branch?
Comment 7 Olav Vitters 2017-02-19 22:51:26 UTC 
Ignore previous remark, it was included.
Comment 8 Ray Strode [halfline] 2017-02-19 23:32:16 UTC 
IIRC, there was a follow up fix after this but cant check right now.  If so, could be it didnt make it to a branch.
Comment 9 Emmanuele Bassi (:ebassi) 2017-02-20 00:36:06 UTC 
It also doesn't really matter unless you're trying to use a version of Mutter prior to 3.20; nothing else uses the KMS backend of Cogl, and after 3.20 Mutter includes its own copy of Cogl anyway.
Comment 10 Olav Vitters 2017-02-20 08:19:55 UTC 
I'll have the user file a new bugreport on GNOME Bugzilla. We're running latest mutter (3.22.something) that was released a few days ago.


https://bugs.mageia.org/show_bug.cgi?id=20261
> Ending a GNOME session under Wayland results in a black screen of death
> (monitor is going forever to power saving mode). No inputs (keyboard and mouse)
> can wake it up, though magic SysRq are still working to reboot the computer.
etc. User thought it might be this bug. Apparently not.