After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756911 - PEP8 cleanup
PEP8 cleanup
Status: RESOLVED FIXED
Product: meld
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: meld-maint
meld-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-21 13:40 UTC by David Rabel
Modified: 2015-10-25 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Code cleanup to get more close to PEP8 (17.55 KB, patch)
2015-10-21 14:07 UTC, David Rabel
none Details | Review

Description David Rabel 2015-10-21 13:40:15 UTC
Minor cleanups of the code to be more PEP8-conform ( https://www.python.org/dev/peps/pep-0008/ )

Kai wrote at meld-list@gnome.org to this topic: 

"
The problem with PEP8-ing all of the current code is that it adds
noise to our git history. The problem isn't the commits themselves,
but rather the git annotate (i.e., blame) output, which will show the
spurious not-really-a-change commit introduced by PEP8 for any
affected code. This can be particularly annoying in older, large files
(i.e., don't bother trying to fix filediff or dirdiff).

As a general rule, I'll probably accept patches for PEP8ing files
where the changes aren't too big, particularly when the file is
almost-PEP8 already. For some files where the 79 character limit has
already been tossed out the window, I wouldn't bother trying to
reinstate that one just yet.

It's worth mentioning two PEP8 caveats. Firstly, PEP8 allows backslash
continuations for long lines, but we don't use them (by which I
mean... we don't use them *any more*). Secondly, PEP8 allows aligned
hanging indents for continued lines, but I would strongly discourage
this.
"
Comment 1 David Rabel 2015-10-21 14:07:04 UTC
Created attachment 313816 [details] [review]
Code cleanup to get more close to PEP8
Comment 2 Kai Willadsen 2015-10-25 20:38:47 UTC
Yep, that all looks good to me. I've pushed your patch to master. Thanks!