After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756883 - Add an option for line wrapping in a quoted text
Add an option for line wrapping in a quoted text
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Composer
3.17.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Tomas Popela
Evolution QA team
: 757505 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-10-20 17:13 UTC by Milan Crha
Modified: 2016-04-15 10:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Milan Crha 2015-10-20 17:13:38 UTC 
Moving this from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1273403

Some people like to have the quoted parts wrapped (bug #650645, bug #732139), but some not. It does make sense in some cases, but not in another.

Let's have a UI option, in Edit->Preferences->Composer Preferences->Replies and Forwards section->Wrap quoted text in replies, with a default to TRUE. Users whom do not like this option can turn it off easily, instead of selecting whole quotation and changing paragraph style from Normal to Preformatted.
Comment 1 Jeff Layton 2015-10-20 17:49:57 UTC 
Yes, please...

Also fwiw, changing from "Normal" to "Preformatted" is not really a workaround. It does remove the extra LFs that were added, but the quoted then has a bunch of '>' sprinkled in the middle of the lines. That seems like a bug, really...

FWIW, I'm running evolution-3.16.5-3.fc22.x86_64.
Comment 2 Tomas Popela 2015-10-21 09:35:45 UTC 
(In reply to Jeff Layton from comment #1)
> workaround. It does remove the extra LFs that were added, but the quoted
> then has a bunch of '>' sprinkled in the middle of the lines. That seems
> like a bug, really...

Please open a separate bug for it, attach the reproducer (message) and describe the exact steps how to reproduce it.
Comment 3 Jeff Layton 2015-10-21 10:39:11 UTC 
Done -- see bug #756900.
Comment 4 Tomas Popela 2015-10-21 11:56:22 UTC 
Fixed with following commit:

    Bug 756883 - Add an option for line wrapping in a quoted text
    
    This patch adds a new "Wrap quoted text in replies" option under the
    "Edit->Preferences->Composer Preferences->Replies and Forwards" section in
    preferences. If set to FALSE the quoted text in replies will be parsed to
    'Preformated' blocks and the won't be wrapped. The option is set to TRUE by
    default, so the behavior won't change for current users.
    
    Also rename various variables/functions around code that parses the HTML to
    blocks to reflect that we are not parsing just to paragraphs.

commit f436ed10b8a8b2ed3b9c418e7706a7526848fc5c in the master branch for Evolution 3.19.1+
Comment 5 Tomas Popela 2015-11-03 05:53:10 UTC 
*** Bug 757505 has been marked as a duplicate of this bug. ***
Comment 6 Tomas Popela 2016-04-15 10:35:32 UTC 
*** Bug 765092 has been marked as a duplicate of this bug. ***