After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756876 - srtp: Fix critical warning trying to retrieve SSRC from a non fb message
srtp: Fix critical warning trying to retrieve SSRC from a non fb message
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal normal
: 1.6.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-20 15:12 UTC by sancane
Modified: 2015-10-23 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix critical warning (764 bytes, patch)
2015-10-20 15:12 UTC, sancane 		committed Details | Review

Description sancane 2015-10-20 15:12:01 UTC 
Created attachment 313757 [details] [review]
fix critical warning

I'm getting this warning whenever rtcp_buffer_get_ssrc is invoked and buffer is an GST_RTCP_TYPE_APP:
 CRITICAL **: gst_rtcp_packet_fb_get_sender_ssrc: assertion '(packet->type == GST_RTCP_TYPE_RTPFB || packet->type == GST_RTCP_TYPE_PSFB)' failed

This patch only try to get the ssrc from a fb message when the type is either GST_RTCP_TYPE_PSFB or GST_RTCP_TYPE_RTPFB.
Comment 1 Sebastian Dröge (slomo) 2015-10-23 13:32:50 UTC 
commit 073bff8ce217d4c44614bf4027b38d63ee1cbe11
Author: Santiago Carot-Nemesio <sancane@gmail.com>
Date:   Tue Oct 20 17:09:22 2015 +0200

    srtp: Fix critical warning trying to retrieve SSRC from a non fb message
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756876