After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756875 - Include ntdef.h for NTSTATUS
Include ntdef.h for NTSTATUS
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 756874 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-10-20 15:06 UTC by Sebastian Dröge (slomo)
Modified: 2016-01-05 09:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Include ntdef.h for NTSTATUS (757 bytes, patch)
2015-10-20 15:06 UTC, Sebastian Dröge (slomo) 		committed Details | Review
winternl.h doesn't exist on mingw32 (280 bytes, patch)
2015-10-27 21:14 UTC, Cédric Krier 		none Details | Review

Description Sebastian Dröge (slomo) 2015-10-20 15:06:33 UTC 
Fixes compilation on Windows and is independent from the other patches.
Comment 1 Sebastian Dröge (slomo) 2015-10-20 15:06:37 UTC 
Created attachment 313755 [details] [review]
Include ntdef.h for NTSTATUS
Comment 2 Sebastian Dröge (slomo) 2015-10-20 17:02:45 UTC 
*** Bug 756874 has been marked as a duplicate of this bug. ***
Comment 3 Ignacio Casal Quinteiro (nacho) 2015-10-20 17:04:27 UTC 
Review of attachment 313755 [details] [review]:

Looks good.
Comment 4 Fan, Chun-wei 2015-10-24 03:23:12 UTC 
Hi,

For records, I have further fixed the build of gwin32.c by including winternl.h, as ntdef.h is normally shipped with MinGW, not Visual Studio[1].  Please let me know if including winternl.h does not work for you (I have checked in the mingw-w64 headers and the winternl.h there does include NTSATUS).

[1]: master: 556705c
     glib-2-46: 7e9c7a1
     glib-2-44: 248ed96

With blessings.
Comment 5 Sebastian Dröge (slomo) 2015-10-24 08:40:27 UTC 
Makes sense, winternl.h exists with mingw too and also typedefs NTSTATUS. Thanks!
Comment 6 Cédric Krier 2015-10-27 21:14:41 UTC 
Created attachment 314261 [details] [review]
winternl.h doesn't exist on mingw32

For me, winternl.h doesn't exist on mingw32 so I need this patch to compile.
Comment 7 Sebastian Dröge (slomo) 2015-12-28 10:00:26 UTC 
Fan, did you see Cédric's comment?
Comment 8 Fan, Chun-wei 2016-01-05 07:20:47 UTC 
Hello Sebastian,

I have pushed a patch that is based on Cédric's on master, glib-2-46 and glib-2-44, which should deal with the issue.

Sorry for the delay.

With blessings, Happy New Year!
Comment 9 Paolo Borelli 2016-01-05 09:51:54 UTC 
While this specific patch is trivial and it is ok to have, I think we should really drop support for mingw32, it is a dead project and has been superseded by mingw64 in every aspect.

I think we should error out in configure and just point people to mingw64