After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756872 - Double-click delay belongs to the Universal Access panel
Double-click delay belongs to the Universal Access panel
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Universal Access
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-20 14:38 UTC by Felipe Borges
Modified: 2015-10-21 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
universal-access: add Double-click delay to Pointing & Clicking section (6.59 KB, patch)
2015-10-20 14:39 UTC, Felipe Borges 		none Details | Review
universal-access: add Double-click delay to Pointing & Clicking section (6.62 KB, patch)
2015-10-21 08:34 UTC, Felipe Borges 		reviewed Details | Review
screenshot (28.59 KB, image/png)
2015-10-21 08:35 UTC, Felipe Borges 		  Details

Description Felipe Borges 2015-10-20 14:38:16 UTC 
.
Comment 1 Felipe Borges 2015-10-20 14:39:35 UTC 
Created attachment 313754 [details] [review]
universal-access: add Double-click delay to Pointing & Clicking section

According to the new Mouse & Touchpad panel designs at
https://wiki.gnome.org/Design/SystemSettings/Mouse, Double-click
belongs to the Universal Access panel.
Comment 2 Bastien Nocera 2015-10-20 14:44:06 UTC 
Review of attachment 313754 [details] [review]:

Can you please attach a screenshot for the designers to look at?

In the old mouse & touchpad panel, we had "slow/fast" labels at either end, do we need those? We might also want to show a mark for the default value.

::: panels/universal-access/uap.ui
@@ +768,3 @@
+                                        <property name="margin_bottom">6</property>
+                                        <property name="xalign">0</property>
+                                        <property name="label" translatable="yes">_Double-click</property>

"_Double-click delay" ?
Comment 3 Felipe Borges 2015-10-21 08:34:39 UTC 
Created attachment 313792 [details] [review]
universal-access: add Double-click delay to Pointing & Clicking section

According to the new Mouse & Touchpad panel designs at
https://wiki.gnome.org/Design/SystemSettings/Mouse, Double-click
delay belongs to the Universal Access panel.
Comment 4 Felipe Borges 2015-10-21 08:35:59 UTC 
Created attachment 313793 [details]
screenshot
Comment 5 Bastien Nocera 2015-10-21 09:05:29 UTC 
Review of attachment 313792 [details] [review]:

Looking at the screenshot, the only thing that concerns me is the amount of padding around the slider, it feels cramped.

The code itself is fine, so commit after branching gnome-control-center once you've fixed the niggles with the designers.

::: panels/universal-access/uap.ui
@@ +785,3 @@
+                                        <child internal-child="accessible">
+                                          <object class="AtkObject" id="double_click_scale-atkobject">
+                                            <property name="AtkObject::accessible-description" translatable="yes">Double-click timeout</property>

Should probably be the same string as the label.