After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756870 - Don't disable assertions for releases and provide a new GST_ENABLE_EXTRA_CHECKS #define
Don't disable assertions for releases and provide a new GST_ENABLE_EXTRA_CHEC...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-20 14:29 UTC by Sebastian Dröge (slomo)
Modified: 2015-10-21 11:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't disable assertions for releases and provide a new GST_ENABLE_EXTRA_CHECKS #define (2.49 KB, patch)
2015-10-20 14:29 UTC, Sebastian Dröge (slomo) 		committed Details | Review
Use new GST_ENABLE_EXTRA_CHECKS #define (2.32 KB, patch)
2015-10-20 14:30 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2015-10-20 14:29:23 UTC 
See commit message
Comment 1 Sebastian Dröge (slomo) 2015-10-20 14:29:27 UTC 
Created attachment 313749 [details] [review]
Don't disable assertions for releases and provide a new GST_ENABLE_EXTRA_CHECKS #define

Assertions are useful to have in any case, and we were abusing the #define for
adding extra checks to our code. Let's do it properly!
Comment 2 Sebastian Dröge (slomo) 2015-10-20 14:30:07 UTC 
Created attachment 313750 [details] [review]
Use new GST_ENABLE_EXTRA_CHECKS #define
Comment 3 Tim-Philipp Müller 2015-10-20 16:13:41 UTC 
+1
Comment 4 Matthew Waters (ystreet00) 2015-10-20 17:24:24 UTC 
Review of attachment 313749 [details] [review]:

Looks good.
Comment 5 Matthew Waters (ystreet00) 2015-10-20 17:25:21 UTC 
Review of attachment 313750 [details] [review]:

Looks good.  Probably need to check all the modules for this then.
Comment 6 Sebastian Dröge (slomo) 2015-10-20 17:46:18 UTC 
I did, no other are using G_DISABLE_ASSERT like this :) But I'll add the configure parameter to all of them nonetheless. Pushing later.
Comment 7 Sebastian Dröge (slomo) 2015-10-21 11:22:58 UTC 
Comment on attachment 313749 [details] [review]
Don't disable assertions for releases and provide a new GST_ENABLE_EXTRA_CHECKS #define

commit b99800a301ce85262a9e33e17d5a137610375c24
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Oct 20 17:28:22 2015 +0300

    Don't disable assertions for releases and provide a new GST_ENABLE_EXTRA_CHECKS #define
    
    Assertions are useful to have in any case, and we were abusing the #define for
    adding extra checks to our code. Let's do it properly!
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756870
Comment 8 Sebastian Dröge (slomo) 2015-10-21 11:32:34 UTC 
Comment on attachment 313750 [details] [review]
Use new GST_ENABLE_EXTRA_CHECKS #define

commit 1efb4511542446b3c9e5b199fb2278236e559538
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Oct 20 17:29:42 2015 +0300

    Use new GST_ENABLE_EXTRA_CHECKS #define
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756870