After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756749 - click action: Only cancel long press on motions/updates from the right devices
click action: Only cancel long press on motions/updates from the right devices
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterAction
1.20.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-17 14:40 UTC by Carlos Garnacho
Modified: 2015-10-17 16:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
click-action: Ignore motions/updates from different devices/sequences (1.07 KB, patch)
2015-10-17 14:41 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2015-10-17 14:40:44 UTC 
In ClutterGestureAction event handler, it does correctly check for the event coming from the right device/sequence for press/release events (both touch and pointer), but forgets to do so on motion/update events, so it can end up triggering CLUTTER_LONG_PRESS_CANCEL when receiving motion from other devices (most likely far from the threshold).

I'm attaching a patch fixing that.
Comment 1 Carlos Garnacho 2015-10-17 14:41:20 UTC 
Created attachment 313539 [details] [review]
click-action: Ignore motions/updates from different devices/sequences

Otherwise events from other devices or touch sequences might unintendedly
trigger the thresholds, and ::cancelled with it.
Comment 2 Emmanuele Bassi (:ebassi) 2015-10-17 15:08:55 UTC 
Review of attachment 313539 [details] [review]:

Looks good.
Comment 3 Carlos Garnacho 2015-10-17 16:47:21 UTC 
Cheers :), pushed.


Attachment 313539 [details] pushed as 9753c99 - click-action: Ignore motions/updates from different devices/sequences