Created attachment 313477 [details] [review]
joinDialog: Don't close when saving new account

The whole point of allowing users to create new connections directly
from the join dialog was to ease the task of joining a room; closing
the dialog on account creation and requiring the user to open the
dialog again clearly defeats that purpose.

Created attachment 313478 [details] [review]
joinDialog: Select newly-created accounts

If the user creates a new connection from the join dialog, it's safe
to assume that she intends to join a room on that server.

Review of attachment 313477 [details] [review]:

LGTM. :)

as for the second patch tho...

Review of attachment 313478 [details] [review]:

::: src/connections.js
@@ +192,3 @@
                                                            GObject.ParamFlags.READABLE,
                                                            false)},
+    Signals: { 'account-created': { param_types: [Tp.Account.$gtype] }},

What does this line mean? Haven't seen this syntax before.

::: src/joinDialog.js
@@ +80,3 @@
+        this._details.connect('account-created', Lang.bind(this,
+            function(details.account) {
+                this._connectionCombo.set_active_id(account.display_name);

getting
(org.gnome.Polari:9367): Gjs-CRITICAL **: JS ERROR: SyntaxError: missing ) after formal parameters @ resource:///org/gnome/Polari/js/joinDialog.js:81

here

Created attachment 313491 [details] [review]
joinDialog: Select newly-created accounts

(In reply to Bastian Ilsø from comment #4)
> Review of attachment 313478 [details] [review] [review]:
> GObject.ParamFlags.READABLE,
>                                                             false)},
> +    Signals: { 'account-created': { param_types: [Tp.Account.$gtype] }},
> 
> What does this line mean? Haven't seen this syntax before.

ConnectionDetails is a widget, ergo a GObject subclass - this defines a (GObject) signal that works with the regular g_signal_connect()/g_signal_emit() methods. Alternatively I could add the same hack as in Application, using connectJS and emitJS ...


> ::: src/joinDialog.js
> @@ +80,3 @@
> (org.gnome.Polari:9367): Gjs-CRITICAL **: JS ERROR: SyntaxError: missing )
> after formal parameters @ resource:///org/gnome/Polari/js/joinDialog.js:81
> 
> here

Grumble - that's called "hey-let's-do-this-small-cleanup-before-attaching" change :-(

Attachment 313477 [details] pushed as 84ff117 - joinDialog: Don't close when saving new account
Attachment 313491 [details] pushed as 6f276e3 - joinDialog: Select newly-created accounts