After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756694 - datatime: Make use of new Geoclue convenience library
datatime: Make use of new Geoclue convenience library
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: datetime
unspecified
Other All
: Normal normal
: ---
Assigned To: Kalev Lember
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-16 13:15 UTC by Zeeshan Ali
Modified: 2015-10-21 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
datatime: Make use of new Geoclue convenience library (11.57 KB, patch)
2015-10-16 13:15 UTC, Zeeshan Ali 		none Details | Review
datetime: Make use of new Geoclue convenience library (11.57 KB, patch)
2015-10-16 13:32 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2015-10-16 13:15:55 UTC 
Here is a small gift. :) I have not tested it to work so please do test it. I'll be rolling out a geoclue release before 3.19.1 tarballs due date so you can already merge it if it works.
Comment 1 Zeeshan Ali 2015-10-16 13:15:59 UTC 
Created attachment 313458 [details] [review]
datatime: Make use of new Geoclue convenience library
Comment 2 Bastien Nocera 2015-10-16 13:28:51 UTC 
Review of attachment 313458 [details] [review]:

> datatime: Make use of new Geoclue convenience library

Typo

The rest of the patch looks fine, will need testing though.
Comment 3 Zeeshan Ali 2015-10-16 13:32:50 UTC 
Created attachment 313460 [details] [review]
datetime: Make use of new Geoclue convenience library

v2: Fix typo in commit log.
Comment 4 Kalev Lember 2015-10-20 11:28:20 UTC 
Review of attachment 313460 [details] [review]:

Thanks Zeeshan! The patch looks good to me and seems to be working fine in quick testing.
Comment 5 Bastien Nocera 2015-10-20 11:31:12 UTC 
Review of attachment 313460 [details] [review]:

We haven't branched.
Comment 6 Zeeshan Ali 2015-10-21 13:54:51 UTC 
Comment on attachment 313460 [details] [review]
datetime: Make use of new Geoclue convenience library

Branched gnome-3-18 and pushed it to master. Thanks for testing Kalev.