After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756684 - Support (not nullable) annotation
Support (not nullable) annotation
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: 1.25
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-16 10:20 UTC by fakey
Modified: 2015-11-19 07:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mkdb: support (not nullable) annotation (1.06 KB, patch)
2015-10-16 10:20 UTC, fakey
none Details | Review
gtkdoc-mkdb: Add support for (not nullable) annotations (5.48 KB, patch)
2015-11-06 12:03 UTC, Philip Withnall
committed Details | Review
gtkdoc-mkdb: Add support for (not nullable) annotations (5.50 KB, patch)
2015-11-19 07:20 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description fakey 2015-10-16 10:20:05 UTC
Created attachment 313444 [details] [review]
mkdb: support (not nullable) annotation

(not nullable) is available in gobject-introspection:

https://git.gnome.org/browse/gobject-introspection/commit/?id=10cb665fee2cc378dd2f13bad16e6384836a8b16

https://bugzilla.gnome.org/show_bug.cgi?id=729660
Comment 1 Philip Withnall 2015-11-06 12:03:21 UTC
Created attachment 314977 [details] [review]
gtkdoc-mkdb: Add support for (not nullable) annotations

In bug #729660, gobject-introspection gained support for a (not
nullable) annotation which is the exact opposite of (nullable).

Add support for that to gtkdoc-mkdb, and add some unit tests.

---

I spotted the existing patch for this after writing my own patch, sorry. The wording in the two differs slightly. Mine has unit tests.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2015-11-19 07:17:46 UTC
Review of attachment 314977 [details] [review]:

Thanks, merging now.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2015-11-19 07:20:30 UTC
The following fix has been pushed:
c567d9e gtkdoc-mkdb: Add support for (not nullable) annotations
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2015-11-19 07:20:37 UTC
Created attachment 315866 [details] [review]
gtkdoc-mkdb: Add support for (not nullable) annotations

In bug #729660, gobject-introspection gained support for a (not
nullable) annotation which is the exact opposite of (nullable).

Add support for that to gtkdoc-mkdb, and add some unit tests.