After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756679 - gio-unix includes introspected with absolute paths
gio-unix includes introspected with absolute paths
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: g-ir-scanner
1.46.x
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-16 07:40 UTC by Mikhail Zabaluev
Modified: 2015-10-19 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Generate relative paths for gio-unix C header includes (1.15 KB, patch)
2015-10-18 10:26 UTC, Mikhail Zabaluev
committed Details | Review

Description Mikhail Zabaluev 2015-10-16 07:40:18 UTC
In the generated GIR for Gio-2.0, the <c:include/> elements for gio-unix headers get emitted with absolute pathnames. Obviously, this does not work well when GIR needs to be checked into repositories, is used to build in other locations, etc.

Might be related to bug #584936.
Comment 1 Mikhail Zabaluev 2015-10-18 10:26:00 UTC
Created attachment 313612 [details] [review]
Generate relative paths for gio-unix C header includes
Comment 2 Colin Walters 2015-10-19 14:59:26 UTC
Review of attachment 313612 [details] [review]:

LGTM - but before pushing, can you copy the rationale you wrote in the bug report into the commit message?  I trust in the longevity of git, less so Bugzilla =)

I think tools like git-bz should do this, though lately I've just been using git format-patch by hand.
Comment 3 Mikhail Zabaluev 2015-10-19 17:42:40 UTC
Attachment 313612 [details] pushed as cb956f5 - Generate relative paths for gio-unix C header includes