GNOME Bugzilla – Bug 756644
Mark files without parent as hidden
Last modified: 2015-11-19 09:43:30 UTC
Files without the parent are currently shown in google backend root. You can see many files consequently, which are not shown in your google drive folder on the web. Those files can be shared with you, or you opened them in some google applications (i.e. google docs).
Created attachment 313377 [details] [review] google: Mark files without parent as hidden Mark those files as hidden to see same files as you can see on the web. Also mark the files as undeletable, because it is not possible to delete them from the obvious reason.
Review of attachment 313377 [details] [review]: Looks good to me, but I can not test it because I lost the parent=[] file that I had in my Drive. Can you share something with me? A few nitpicks: ::: daemon/gvfsbackendgoogle.c @@ +902,3 @@ gint64 mtime; gsize i; + GList *links; Maybe put it below the 'GList *authors' above? @@ +914,3 @@ + g_list_free (links); + + g_file_info_set_attribute_boolean (info, G_FILE_ATTRIBUTE_ACCESS_CAN_DELETE, !is_root && has_parent); Maybe put it together with CAN_TRASH? And since we are using 'goto out' move the g_list_free to the 'out' section at the end of the function for consistency?
Created attachment 313416 [details] [review] google: Mark files you can't see on the web as hidden Modified as per the nitpicks... Try to open following file to test: https://drive.google.com/file/d/0B9zPQZeTJSW6Q2U4cFRUd0NfbUk/view?usp=sharing
Review of attachment 313416 [details] [review]: Thanks for the changes, Ondrej. It works as expected.
Comment on attachment 313416 [details] [review] google: Mark files you can't see on the web as hidden commit 3aade766e1793bbf3ba2ecd29aba44d0467a0c6d
Thanks for review.
*** Bug 758292 has been marked as a duplicate of this bug. ***