GNOME Bugzilla – Bug 756623
No Polish diacritic letters
Last modified: 2016-02-15 14:34:43 UTC
Hi, I see there are various diacritic letters already but not all used in Polish. I'd like to request ą, ę, ł, ż, ź (under Z as well as X), ć and ń.
*** Bug 756627 has been marked as a duplicate of this bug. ***
Created attachment 318654 [details] [review] Add Polish special characters to fullscale qwerty layout I added the missing special characters, but I wasn't sure where to place them. I'd like to have them as close to the main character as possible, but that might collide with the needs of other languages. Is it possible to create a custom layout for a language?
Created attachment 318655 [details] [review] Add Polish special characters to touch qwerty layout
Created attachment 318656 [details] [review] Add Polish fullscale layout I don't know if this is needed, but I've created it just in case.
Created attachment 318657 [details] [review] Add Polish touch layout
Created attachment 320880 [details] [review] Add Polish special characters to tablet qwerty layout
Created attachment 320881 [details] [review] Add Polish tablet layout
Thanks. I have tried the touch layout with: ./bin/antler-keyboard -c preview -f data/layouts/touch/pl.xml and noticed that some keys are displayed as empty, because of wrong keysym names: [aeAE]ogon -> [aeAE]ogonek [lL]strok -> [lL]stroke [zZ]dot -> [zZ]abovedot Could you confirm that?
I was using HTML entity names from https://en.wikipedia.org/wiki/Polish_orthography#Computer_encoding which I guess are incorrect. Following is a v2 of the patch series, with your suggestions incorporated.
Created attachment 321148 [details] [review] Add Polish special characters to fullscale qwerty layout v2
Created attachment 321149 [details] [review] Add Polish special characters to touch qwerty layout v2
Created attachment 321150 [details] [review] Add Polish special characters to tablet qwerty layout v2
Created attachment 321151 [details] [review] Add Polish fullscale layout v2
Created attachment 321152 [details] [review] Add Polish touch layout v2
Created attachment 321153 [details] [review] Add Polish tablet layout v2
Review of attachment 321148 [details] [review]: looks good
Review of attachment 321149 [details] [review]: looks good
Review of attachment 321150 [details] [review]: looks good
(In reply to Piotr Drąg from comment #9) > I was using HTML entity names from > https://en.wikipedia.org/wiki/Polish_orthography#Computer_encoding which I > guess are incorrect. > > Following is a v2 of the patch series, with your suggestions incorporated. Thanks, the first 3 patches look good to me. However, I doubt that the latter 3 patches are really useful if you directly modify common/qwerty.xml; if there is no "pl" layout, caribou should fallback to "us", which already has the Polish characters by now. I guess it would be useful if you write a complete Polish layout as you see with: gkbd-keyboard-display -l pl, though.
Thank you very much. Pushed: https://git.gnome.org/browse/caribou/commit/?id=984ee480111d5374bed6d6d74aaccdb05de2c829 https://git.gnome.org/browse/caribou/commit/?id=f4e6712d17b0394d8041f2c9fd3f6fe74f9ff6db https://git.gnome.org/browse/caribou/commit/?id=d4633ee3fda249bcb37d30f202c1832b6b45ccd9