After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756586 - geo: Make use of new Geoclue convenience library
geo: Make use of new Geoclue convenience library
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-14 18:43 UTC by Zeeshan Ali
Modified: 2015-10-23 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
geo: Make use of new Geoclue convenience library (5.59 KB, patch)
2015-10-14 18:43 UTC, Zeeshan Ali
committed Details | Review

Description Zeeshan Ali 2015-10-14 18:43:33 UTC
In my simple and quick tests, this patch works. More testing is welcome of course.

I wouldn't merge this patch yet though and wait for the new API to be released first. It goes without saying that this is meant for 3.20.
Comment 1 Zeeshan Ali 2015-10-14 18:43:37 UTC
Created attachment 313322 [details] [review]
geo: Make use of new Geoclue convenience library
Comment 2 Paolo Borelli 2015-10-14 19:56:01 UTC
Review of attachment 313322 [details] [review]:

The patch looks good to me and does not seem to interact with the extra logic about checking the country of the location etc.

I agree this can go on master once there is a public version of the library
Comment 3 Zeeshan Ali 2015-10-23 12:45:17 UTC
(In reply to Paolo Borelli from comment #2)
> Review of attachment 313322 [details] [review] [review]:
> 
> The patch looks good to me and does not seem to interact with the extra
> logic about checking the country of the location etc.
> 
> I agree this can go on master once there is a public version of the library

Actually, I think we should merge this already so it get tested before going into a release. I already merged the patch for gnome-settings-daemon and getting other apps to do the same.
Comment 4 Paolo Borelli 2015-10-23 13:27:29 UTC
Ok, feel free to go ahead
Comment 5 Zeeshan Ali 2015-10-23 13:37:03 UTC
Attachment 313322 [details] pushed as 3d49eb6 - geo: Make use of new Geoclue convenience library