After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756573 - pcapparse: Crash in presence of empty packet
pcapparse: Crash in presence of empty packet
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
Other Linux
: Normal normal
: 1.6.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-10-14 14:33 UTC by Nicolas Dufresne (ndufresne)
Modified: 2015-12-23 23:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

sample pcap with empty packets (5.00 KB, application/octet-stream)
2015-12-23 23:20 UTC, Tim-Philipp Müller

Description Nicolas Dufresne (ndufresne) 2015-10-14 14:33:25 UTC
pcapparse does not handle packet without a payload size of 0, and crash. I cannot share the sample, but a simple code inspection is enough to see there is no protection against 0 payload packet. We should probably skip does packet.

Meanwhile, I'm a bit suspicious, as for the same sample, I don't hit this situation with 1.4. So the payload size 0 might just be indicator of another regression. I'll try to see if I can free the sample meanwhile.
Comment 1 Sebastian Dröge (slomo) 2015-10-19 12:22:50 UTC
An empty buffer without content might be better than dropping.
Comment 2 Tim-Philipp Müller 2015-12-23 23:18:33 UTC
commit c1494a558cada71c1318c160acaf819e3a82ac68
Author: Tim-Philipp Müller <>
Date:   Wed Dec 23 23:10:50 2015 +0000

    tests: pcapparse: add check for 0-sized packets

commit 9a20a7c77bd33b92bd195fc508fb566394c4dd11
Author: Tim-Philipp Müller <>
Date:   Wed Dec 23 20:24:46 2015 +0000

    pcapparse: don't crash on 0-sized packets
Comment 3 Tim-Philipp Müller 2015-12-23 23:20:10 UTC
Created attachment 317831 [details]
sample pcap with empty packets