After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756560 - the very last stage of file copy presents an ugly popover
the very last stage of file copy presents an ugly popover
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-14 09:33 UTC by Jakub Steiner
Modified: 2015-11-12 20:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
narrow blank popover (52.22 KB, image/png)
2015-10-14 09:33 UTC, Jakub Steiner 		  Details
screencast of the issue (1.15 MB, video/webm)
2015-10-15 13:21 UTC, Jakub Steiner 		  Details
toolbar: avoid empty operations popover (4.33 KB, patch)
2015-11-12 20:43 UTC, Carlos Soriano 		committed Details | Review

Description Jakub Steiner 2015-10-14 09:33:33 UTC 
Created attachment 313250 [details]
narrow blank popover

When I copy large files over to a smb:// share, the last stage where it feels like 100%, but is still flushing the cache, the popover is black narrow ugliness that we probably don't want to show. Screenshot attached.
Comment 1 Carlos Soriano 2015-10-15 12:06:57 UTC 
Cannot reproduce here... suposedly the operations are not removed until 3 seconds with the button untoggled passed.
Does it always happens to you? Which operation were you performing?
Comment 2 Jakub Steiner 2015-10-15 13:20:47 UTC 
(In reply to Carlos Soriano from comment #1)
> Does it always happens to you? Which operation were you performing?
Copying mp3s from a local drive to a mounted samba share. And yea I was able to reproduce it. Screencast attached.
Comment 3 Jakub Steiner 2015-10-15 13:21:08 UTC 
Created attachment 313369 [details]
screencast of the issue
Comment 4 Carlos Soriano 2015-11-12 20:43:35 UTC 
Created attachment 315371 [details] [review]
toolbar: avoid empty operations popover

We need to check that all windows have the popover hidden
to remove the operations, if not, what happens is that if
one of the windows has it hidden it removes its operations
and all the other popovers become empty.

The code is not very beautiful since we have to access all
the toolbars of all the windows, which is kind of breaking
the design, but well... creating a "operations toolbar manager"
just for this looks overkill.
Comment 5 Carlos Soriano 2015-11-12 20:49:44 UTC 
Attachment 315371 [details] pushed as e5163ba - toolbar: avoid empty operations popover