After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756512 - Add ability to open location in browser
Add ability to open location in browser
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
: 735215 (view as bug list)
Depends on:
Blocks: 757493
 
 
Reported: 2015-10-13 15:33 UTC by Bastien Nocera
Modified: 2015-11-05 15:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Handle the 'geo' URI scheme (3.34 KB, patch)
2015-11-02 10:40 UTC, Jonas Danielsson
committed Details | Review
Cast of opening geo uri from firefox (1.06 MB, video/webm)
2015-11-02 10:41 UTC, Jonas Danielsson
  Details
Add OpenStreetMaps URI to send-to-dialog (6.70 KB, patch)
2015-11-02 15:00 UTC, Jonas Danielsson
none Details | Review
Cast of opening OSM in browser from Maps (1.30 MB, video/webm)
2015-11-02 15:01 UTC, Jonas Danielsson
  Details
Add open with browser to send-to-dialog (6.91 KB, patch)
2015-11-02 15:20 UTC, Jonas Danielsson
none Details | Review
Add open with browser to send-to-dialog (6.91 KB, patch)
2015-11-02 15:23 UTC, Jonas Danielsson
needs-work Details | Review
Cast of opening OSM in browser from Maps (1.31 MB, video/webm)
2015-11-02 15:26 UTC, Jonas Danielsson
  Details
Add open with browser to send-to-dialog (6.97 KB, patch)
2015-11-02 15:33 UTC, Jonas Danielsson
none Details | Review
Add open with browser to send-to-dialog (9.10 KB, patch)
2015-11-02 16:14 UTC, Jonas Danielsson
committed Details | Review
Cast of opening OSM in browser from Maps (883.95 KB, video/webm)
2015-11-02 16:15 UTC, Jonas Danielsson
  Details

Description Bastien Nocera 2015-10-13 15:33:25 UTC
So that users can share that link via mail for example.
Comment 1 Jonas Danielsson 2015-11-02 10:40:28 UTC
Created attachment 314617 [details] [review]
Handle the 'geo' URI scheme

This will let Maps open the geo: URI scheme as
specified by RFC 5870.

In its simplest form it looks like:
    geo:latitude,longitude

An Android extension to set a description is also supported:
    geo:0,0?q=latitude,longitude(description)
Comment 2 Jonas Danielsson 2015-11-02 10:41:12 UTC
Created attachment 314618 [details]
Cast of opening geo uri from firefox
Comment 3 Jonas Danielsson 2015-11-02 10:49:25 UTC
Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.
Comment 4 Jonas Danielsson 2015-11-02 10:49:43 UTC
*** Bug 735215 has been marked as a duplicate of this bug. ***
Comment 5 Jonas Danielsson 2015-11-02 10:50:41 UTC
I did not write that last part, a mistake most likely by me tho. This bug is open and alive.
Comment 6 Damián Nohales 2015-11-02 13:35:12 UTC
Review of attachment 314617 [details] [review]:

Besides the philosophical comment, looks great :)

::: src/mapView.js
@@ +247,3 @@
+                              this._goToGeoURIInternal.bind(this, uri));
+        }
+        } catch(e) {

Just an idea, maybe for later, is it worth to do the realized check stuff inside Application.open method.

It's weird that the view needs to know when its realized within the MapView class for these two particular actions (open GeoURI, open GeoJSON), it looks like MapView knows details about the Application class. If the realized stuff occurs on the Application.open method, that method should be handle it, not every method called by open that intend to use the map view.
Comment 7 Jonas Danielsson 2015-11-02 15:00:38 UTC
Created attachment 314645 [details] [review]
Add OpenStreetMaps URI to send-to-dialog
Comment 8 Jonas Danielsson 2015-11-02 15:01:06 UTC
Created attachment 314646 [details]
Cast of opening OSM in browser from Maps
Comment 9 Jonas Danielsson 2015-11-02 15:20:23 UTC
Created attachment 314649 [details] [review]
Add open with browser to send-to-dialog

This will add your default launcher for the
'https' URI scheme as an option to send-to-dialog.
Comment 10 Jonas Danielsson 2015-11-02 15:23:09 UTC
Created attachment 314650 [details] [review]
Add open with browser to send-to-dialog

This will add your default launcher for the
'https' URI scheme as an option to send-to-dialog.
Comment 11 Jonas Danielsson 2015-11-02 15:26:31 UTC
Created attachment 314652 [details]
Cast of opening OSM in browser from Maps
Comment 12 Bastien Nocera 2015-11-02 15:27:22 UTC
Review of attachment 314650 [details] [review]:

::: src/sendToDialog.js
@@ +47,3 @@
                         'clocksRow',
                         'clocksLabel',
+                        'osmRow',

I'd call it browser row, browser label, etc.
Comment 13 Jonas Danielsson 2015-11-02 15:33:02 UTC
Created attachment 314657 [details] [review]
Add open with browser to send-to-dialog

This will add your default launcher for the
'https' URI scheme as an option to send-to-dialog.
Comment 14 Damián Nohales 2015-11-02 15:44:27 UTC
Review of attachment 314650 [details] [review]:

::: src/sendToDialog.js
@@ +115,3 @@
+        let uriFormat = 'https://www.openstreetmap.org?lat=%f&lon=%f&zoom=%d';
+
+

You must use the place coordinates, not view.
Comment 15 Jonas Danielsson 2015-11-02 16:14:25 UTC
Created attachment 314668 [details] [review]
Add open with browser to send-to-dialog

This will add your default launcher for the
'https' URI scheme as an option to send-to-dialog.
Comment 16 Jonas Danielsson 2015-11-02 16:15:20 UTC
Created attachment 314669 [details]
Cast of opening OSM in browser from Maps
Comment 17 Damián Nohales 2015-11-02 18:13:33 UTC
Review of attachment 314668 [details] [review]:

Looks great!
Comment 18 Jonas Danielsson 2015-11-05 15:26:42 UTC
Attachment 314617 [details] pushed as 548128b - Handle the 'geo' URI scheme
Attachment 314668 [details] pushed as 687b3c1 - Add open with browser to send-to-dialog