Bug 756509 – Error on startup

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 756509 - Error on startup


Summary:	Error on startup


Status:	RESOLVED FIXED

Product:	gnome-maps
Classification:	Applications
Component:	general
Version:	3.18.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gnome-maps-maint
QA Contact:	gnome-maps-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-10-13 15:30 UTC by Bastien Nocera
Modified:	2015-10-14 17:21 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
maps-contact: Check for no street address (1.86 KB, patch) 2015-10-13 18:26 UTC, Jonas Danielsson	committed	Details \| Review

Description Bastien Nocera 2015-10-13 15:30:26 UTC

Looks like it's trying to handle one of my contacts and couldn't parse a street address. How can I export the data to reproduce that?

** (org.gnome.Maps:23180): CRITICAL **: geocode_place_set_street: assertion 'street != NULL' failed

Program received signal SIGTRAP, Trace/breakpoint trap.
0x00007ffff516981b in g_logv () from /lib64/libglib-2.0.so.0
(gdb) bt

+ Trace 235578

#0 g_logv
#1 g_log
#2 on_geocode_search_async
#3 g_simple_async_result_complete
#4 complete_in_idle_cb
#5 g_main_context_dispatch
#6 g_main_context_iterate.isra
#7 g_main_context_iteration
#8 g_application_run
#9 ffi_call_unix64
#10 ffi_call
#11 0x00007ffff7b7b7cb in
#12 0x00007ffff7b7ccc5 in
#13 js::Invoke(JSContext*, JS::CallArgs, js::MaybeConstruct)
#14 Interpret(JSContext*, js::RunState&)
#15 js::ExecuteKernel(JSContext*, JS::Handle<JSScript*>, JSObject&, JS::Value const&, js::ExecuteType, js::AbstractFramePtr, JS::Value*)
#16 js::Execute(JSContext*, JS::Handle<JSScript*>, JSObject&, JS::Value*)
#17 JS::Evaluate(JSContext*, JS::Handle<JSObject*>, JS::CompileOptions, unsigned short const*, unsigned long, JS::Value*)
#18 JS::Evaluate(JSContext*, JS::Handle<JSObject*>, JS::CompileOptions, char const*, unsigned long, JS::Value*)
#19 gjs_eval_with_scope
#20 gjs_context_eval
#21 main

Comment 1 Jonas Danielsson 2015-10-13 18:26:02 UTC

Thanks for filing!

Comment 2 Jonas Danielsson 2015-10-13 18:26:19 UTC

Created attachment 313211 [details] [review]
maps-contact: Check for no street address

Make sure we do not try to add a street if the geocoding
does not produce one.

https://bugzilla.gnome.org/show_bug.cgi?id=756509§

Comment 3 Jonas Danielsson 2015-10-14 05:46:44 UTC

Yeah the question of how you can export this is tricky. It would be very helpful to know which of your contacts generate a geocode answer that does not have a street set, but still gets a location. (Since no blowup about NULL location).

Do you have a lot of contacts with addresses?

Comment 4 Jonas Danielsson 2015-10-14 05:52:00 UTC

Or, it is not strange at all. It would just take having a contact that has no street set... like just a city or a country.

Do you think it makes sense to do an extra release at times like this? Like a 3.18.1.1 (or a 3.18.2)?

Thanks!

Comment 5 Bastien Nocera 2015-10-14 09:02:56 UTC

It fixes the warning(s) on startup. I've found a few more bugs though.

Comment 6 Jonas Danielsson 2015-10-14 17:21:25 UTC

Attachment 313211 [details] pushed as 64a5e3d - maps-contact: Check for no street address