Bug 756454 – Crash in ggit_signature_get_time on repo loading.

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 756454 - Crash in ggit_signature_get_time on repo loading.


Summary:	Crash in ggit_signature_get_time on repo loading.


Status:	RESOLVED FIXED

Product:	gitg
Classification:	Applications
Component:	gitg
Version:	3.18.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gitg-maint
QA Contact:	gitg-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-10-12 17:50 UTC by pedrum
Modified:	2016-04-26 17:33 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Backtrace (31.31 KB, text/plain) 2015-12-28 20:32 UTC, Marcin Zajaczkowski	Details

Description pedrum 2015-10-12 17:50:13 UTC

I get a segfault on repo loading (same repo I had issues with in #748974). This occurred with gitg 3.18.0 on Arch.

+ Trace 235572

#0 g_date_time_to_timezone
from /usr/lib/libglib-2.0.so.0
#1 ggit_signature_get_time
from /usr/lib/libgit2-glib-1.0.so.0
#2 gitg_history_ref_row_compare_to
#3 ??
#4 ??
from /usr/lib/libglib-2.0.so.0
#5 ??
from /usr/lib/libglib-2.0.so.0
#6 g_sequence_insert_sorted_iter
from /usr/lib/libglib-2.0.so.0
#7 g_sequence_insert_sorted
from /usr/lib/libglib-2.0.so.0
#8 gtk_list_box_insert
from /usr/lib/libgtk-3.so.0
#9 gitg_history_refs_list_add
#10 ??
#11 ??
#12 git_reference_foreach_name
from /usr/lib/libgit2.so.23
#13 ggit_repository_references_foreach_name
from /usr/lib/libgit2-glib-1.0.so.0
#14 gitg_history_refs_list_set_repository
#15 g_object_set_property
from /usr/lib/libgobject-2.0.so.0
#16 ??
from /usr/lib/libgobject-2.0.so.0
#17 g_object_bind_property_full
from /usr/lib/libgobject-2.0.so.0
#18 g_object_bind_property_with_closures
from /usr/lib/libgobject-2.0.so.0
#19 ??
#20 ??
#21 ??
#22 gitg_ui_elements_construct_with_builtin
#23 gitg_ui_elements_new_with_builtin
#24 ??
#25 gitg_window_create_new
#26 ??
#27 ??
#28 ffi_call_unix64
from /usr/lib/libffi.so.6
#29 ffi_call
from /usr/lib/libffi.so.6
#30 g_cclosure_marshal_generic_va
from /usr/lib/libgobject-2.0.so.0
#31 ??
from /usr/lib/libgobject-2.0.so.0
#32 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#33 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#34 ??
#35 ffi_call_unix64
from /usr/lib/libffi.so.6
#36 ffi_call
from /usr/lib/libffi.so.6
#37 g_cclosure_marshal_generic_va
from /usr/lib/libgobject-2.0.so.0
#38 ??
from /usr/lib/libgobject-2.0.so.0
#39 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#40 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#41 ??
from /usr/lib/libgio-2.0.so.0
#42 ??
from /usr/lib/libgio-2.0.so.0
#43 ??
#44 g_application_run
from /usr/lib/libgio-2.0.so.0
#45 gitg_main_main
#46 __libc_start_main
from /usr/lib/libc.so.6
#47 _start

Comment 1 Ignacio Casal Quinteiro (nacho) 2015-10-14 09:59:20 UTC

What version of libgit2-glib do you have?

Comment 2 pedrum 2015-10-14 17:43:20 UTC

Here are the package versions in Arch.

libgit2 1:0.23.2-1
libgit2-glib 0.23.6-1

Comment 3 mitch.special 2015-12-02 21:30:36 UTC

Same issue here (also on Arch with roughly the same package versions).  Easily reproducible using Linus' kernel tree:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
$ cd linux
$ gitg

Comment 4 Marcin Zajaczkowski 2015-12-28 20:31:22 UTC

I have similar issue with g_date_time_to_timezone/g_date_time_to_instant in 3.18.0 on Fedora 23.

https://bugzilla.redhat.com/show_bug.cgi?id=1294530

Comment 5 Marcin Zajaczkowski 2015-12-28 20:32:40 UTC

Created attachment 317984 [details]
Backtrace

Comment 6 Ritesh Raj Sarraf 2015-12-30 11:42:53 UTC

I have a similar one in Debian. I think it has a decent backtrace

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809395

And, for me too, it happens on big repositories, like the Linux kernel.

Comment 7 jessevdk@gmail.com 2015-12-30 16:44:27 UTC

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.

Comment 8 Ritesh Raj Sarraf 2015-12-30 16:59:31 UTC

(In reply to jessevdk@gmail.com from comment #7)
> This problem has been fixed in the unstable development version. The fix
> will be available in the next major software release. You may need to
> upgrade your Linux distribution to obtain that newer version.

What version are you referring here ? Can you please specifically mention the version/commit ?

On Debian, the crash was seen on  3.19.x.

Comment 9 jessevdk@gmail.com 2015-12-31 10:10:23 UTC

As it says, it's just fixed and will be available in the next unstable release or stable release, meaning 3.19.4 or 3.20.x.

Comment 10 Jaijeet Roychowdhury 2016-03-10 21:27:59 UTC

Jesse,

The fix does not seem to be in gitg git master (as of today) or the 3.19.6 snapshot. (This is on Arch with gitg linked against a manually compiled gtk-3.19.11.)

Might it be possible for you to post the patch for this bug here so that we can apply it ourselves? The bug is affecting our workflow and a temporary workaround while waiting for an officially released fix would be very useful.

Thanks,

Jaijeet

Comment 11 Alexey Brodkin 2016-04-21 12:54:42 UTC

Even though I haven't compiled today's gitg master branch from commit messages down to 3.19.3 I cannot find anything that might address the problem in question.

Any chance to get a pointer to commit that should fix this gitg failure?

Comment 12 pedrum 2016-04-26 17:33:30 UTC

I'm no longer seeing this issue with gitg 3.20.0.