GNOME Bugzilla – Bug 756446
Pairing code confirmation dialog - UI issues
Last modified: 2015-10-13 15:10:09 UTC
Created attachment 313126 [details] screenshot There's a bunch of issues with the dialog in 3.18 (see the attached screenshot): * It uses both action buttons and a close button in the header bar - should just be action buttons: "Cancel" and "Confirm". * There's no title in the header bar - probably should be something like "Confirm PIN". * The code should be bigger, to make it stand out and easier to read.
commit b71dcf6907f8ac9519cda404198ed6c54cb8f637 (HEAD -> master) Author: Bastien Nocera <hadess@hadess.net> Date: Tue Oct 13 17:07:21 2015 +0200 pairing-dialog: Don't forget to show the title The title was set, but not shown. The problem didn't show in the test application, as it did a "gtk_widget_show_all()" unlike the settings code which simply called "gtk_widget_show()". https://bugzilla.gnome.org/show_bug.cgi?id=756446 commit bf87d34377025bfe7b8d5130a874430d4f774c77 Author: Bastien Nocera <hadess@hadess.net> Date: Tue Oct 13 17:01:36 2015 +0200 pairing-dialog: Hide close button in dialogue It shouldn't have been there in the first place. https://bugzilla.gnome.org/show_bug.cgi?id=756446 commit 274fc6ebabc7b14a0e2e42bff26c39c871296aa2 Author: Bastien Nocera <hadess@hadess.net> Date: Tue Oct 13 17:01:12 2015 +0200 pairing-dialog: Fix lost styling for PINs The styling was lost when moving the GTK+ theme from gnome-themes-standard to GTK+. https://bugzilla.gnome.org/show_bug.cgi?id=756446