After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756412 - Incorrect date format is used.
Incorrect date format is used.
Status: RESOLVED FIXED
Product: l10n
Classification: Infrastructure
Component: British English [en_GB]
git master
Other Linux
: Normal normal
: ---
Assigned To: l10n en_GB maintainers
l10n en_GB maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-12 02:13 UTC by Michael Heyns
Modified: 2015-10-20 14:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (142.15 KB, image/png)
2015-10-12 02:13 UTC, Michael Heyns
Details

Description Michael Heyns 2015-10-12 02:13:06 UTC
Created attachment 313092 [details]
screenshot

I noticed gnome-calendar uses the wrong date format for events. Correct format is set in control center. Screenshot attached.

GNOME 3.18 on Arch Linux
Comment 1 Erick Perez Castellanos 2015-10-16 23:05:26 UTC
The issue here is a translation for en_GB is missing, the same translation exists for gnome-control-center and glib. The same translation as shown in [1] missing is what is causing this bug.

[1]: https://git.gnome.org/browse/glib/tree/po/en_GB.po#n3005
Comment 2 Bastien Nocera 2015-10-20 10:37:05 UTC
Why not use GLib's translation then, instead of making us translate a new one?

const char *format = dpgettext("glib20", "GDateTime", "%m/%d/%y");
Comment 3 Bastien Nocera 2015-10-20 10:40:19 UTC
(In reply to Erick Pérez Castellanos from comment #1)
> The issue here is a translation for en_GB is missing, the same translation
> exists for gnome-control-center and glib.

There's no translations in gnome-control-center either, it uses the "%x" format from g_date_time_format().

https://git.gnome.org/browse/gnome-control-center/tree/panels/region/cc-format-chooser.c#n86
Comment 4 Erick Perez Castellanos 2015-10-20 13:20:05 UTC
(In reply to Bastien Nocera from comment #2)
> Why not use GLib's translation then, instead of making us translate a new
> one?
> 
> const char *format = dpgettext("glib20", "GDateTime", "%m/%d/%y");

I did not know we could do such a thing, yet I think a translation for British English is needed. So, I'll fix this particular issue calling on GLib's translation and the bug can stay to serve a feature tracker for the translation.
Comment 5 Bastien Nocera 2015-10-20 13:30:59 UTC
(In reply to Erick Pérez Castellanos from comment #4)
> (In reply to Bastien Nocera from comment #2)
> > Why not use GLib's translation then, instead of making us translate a new
> > one?
> > 
> > const char *format = dpgettext("glib20", "GDateTime", "%m/%d/%y");
> 
> I did not know we could do such a thing,

FWIW, that's how %x is implemented in GLib's g_date_time_format(), so it might be best to use g_date_time_format() to create your date and time labels, instead of poking directly at the translation.

> yet I think a translation for
> British English is needed. So, I'll fix this particular issue calling on
> GLib's translation and the bug can stay to serve a feature tracker for the
> translation.

There's one string in the UI that needs to be translated (s/Color/Colour/) and that's it...
Comment 6 Bastien Nocera 2015-10-20 13:31:56 UTC
commit f9be13f74b8c07299a21202e8008c362c9fdd33e (HEAD -> master)
Author: Bastien Nocera <hadess@hadess.net>
Date:   Tue Oct 20 15:30:40 2015 +0200

    po: Add British English translation
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756412
Comment 7 Erick Perez Castellanos 2015-10-20 14:40:56 UTC
Pushed fix as commit e81f709