After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756404 - editor-frame: make enter dismiss search entry
editor-frame: make enter dismiss search entry
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-11 20:26 UTC by Ray Strode [halfline]
Modified: 2015-10-11 21:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
editor-frame: make enter dismiss search entry (3.34 KB, patch)
2015-10-11 20:26 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2015-10-11 20:26:23 UTC 
It's a little unexpected that hitting enter keeps the search
entry around. We already have up arrow and down arrow for
going through search results.

This commit makes enter just dismiss the entry.
Comment 1 Ray Strode [halfline] 2015-10-11 20:26:26 UTC 
Created attachment 313079 [details] [review]
editor-frame: make enter dismiss search entry
Comment 2 Christian Hergert 2015-10-11 20:57:07 UTC 
Review of attachment 313079 [details] [review]:

LGTM, and your description sounds reasonable.
Comment 3 Ray Strode [halfline] 2015-10-11 21:24:35 UTC 
(pushed with a minor change slaf found from review on irc)

Attachment 313079 [details] pushed as 566de71 - editor-frame: make enter dismiss search entry