After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756394 - identity: Allow multiple simultaneous sign-in requests from one sender
identity: Allow multiple simultaneous sign-in requests from one sender
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: Kerberos
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-11 15:53 UTC by Ray Strode [halfline]
Modified: 2015-10-14 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
identity: allow multiple sign-in requests in flight at once from one sender (14.78 KB, patch)
2015-10-11 15:53 UTC, Ray Strode [halfline]
none Details | Review
identity: Allow multiple simultaneous sign-in requests from one sender (4.98 KB, patch)
2015-10-14 17:00 UTC, Debarshi Ray
committed Details | Review

Description Ray Strode [halfline] 2015-10-11 15:53:24 UTC
If gnome online accounts has more than one kerberos account associated
with it, then it may do more than one sign in request in quick
succession.

The identity service doesn't handle this very well, since it tracks
secret exchange requests per sender.

This commit addresses the problem by keying secret exchange requests,
based on identity + sender.
Comment 1 Ray Strode [halfline] 2015-10-11 15:53:27 UTC
Created attachment 313065 [details] [review]
identity: allow multiple sign-in requests in flight at once from one sender
Comment 2 Ray Strode [halfline] 2015-10-11 15:55:41 UTC
Review of attachment 313065 [details] [review]:

::: src/goaidentity/org.gnome.Identity.xml
@@ +30,2 @@
     <method name="ExchangeSecretKeys">
+      <arg name="identity" type="s" direction="in"/>

should probably call this "identifier" not "identity" to be consistent with the caller.
Comment 3 Debarshi Ray 2015-10-14 17:00:17 UTC
Created attachment 313293 [details] [review]
identity: Allow multiple simultaneous sign-in requests from one sender

Made the s/identity/identifier/g change. Haven't tested it yet.
Comment 4 Debarshi Ray 2015-10-14 17:39:42 UTC
Seems to work. A ticket obtained via kinit was picked up, and I could create an account through the UI. Stuff didn't crash, no CRITICALs from goa-identity-service. I am reasonably convinced that I didn't fuck it up.
Comment 5 Debarshi Ray 2015-10-14 17:47:32 UTC
Pushed to master and gnome-3-18. It doesn't apply cleanly on the older branches, so I am going to ignore them unless there is a strong need for it.