GNOME Bugzilla – Bug 756394
identity: Allow multiple simultaneous sign-in requests from one sender
Last modified: 2015-10-14 17:47:32 UTC
If gnome online accounts has more than one kerberos account associated with it, then it may do more than one sign in request in quick succession. The identity service doesn't handle this very well, since it tracks secret exchange requests per sender. This commit addresses the problem by keying secret exchange requests, based on identity + sender.
Created attachment 313065 [details] [review] identity: allow multiple sign-in requests in flight at once from one sender
Review of attachment 313065 [details] [review]: ::: src/goaidentity/org.gnome.Identity.xml @@ +30,2 @@ <method name="ExchangeSecretKeys"> + <arg name="identity" type="s" direction="in"/> should probably call this "identifier" not "identity" to be consistent with the caller.
Created attachment 313293 [details] [review] identity: Allow multiple simultaneous sign-in requests from one sender Made the s/identity/identifier/g change. Haven't tested it yet.
Seems to work. A ticket obtained via kinit was picked up, and I could create an account through the UI. Stuff didn't crash, no CRITICALs from goa-identity-service. I am reasonably convinced that I didn't fuck it up.
Pushed to master and gnome-3-18. It doesn't apply cleanly on the older branches, so I am going to ignore them unless there is a strong need for it.