After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756365 - Help: change-theme.page inconsistent with GUI
Help: change-theme.page inconsistent with GUI
Status: RESOLVED FIXED
Product: five-or-more
Classification: Applications
Component: documentation
git master
Other All
: Normal minor
: ---
Assigned To: Maintainers of Gnome user documentation
five-or-more-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-10 22:47 UTC by Anders Jonsson
Modified: 2015-10-14 08:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Mention all themes, use same wording as in GUI (134.24 KB, patch)
2015-10-13 20:45 UTC, Anders Jonsson 		committed Details | Review

Description Anders Jonsson 2015-10-10 22:47:40 UTC 
Filing a bug for some things noticed in C/change-theme.page so they aren't forgotten:


In C/change-theme.page:29: "Image background" is mentioned, but in the GUI this is actually called "Background color".

In C/change-theme.page:29 only the themes "balls" and "shapes" are mentioned, but the GUI has four choices, making the full list "balls, dots, gumball and shapes". Adding images for these two extra themes as well to the page would also be nice.

Regards,
Anders Jonsson
Comment 1 Anders Jonsson 2015-10-13 20:45:08 UTC 
Created attachment 313217 [details] [review]
Mention all themes, use same wording as in GUI

This patch fixes the things mentioned in the bug report, and adds images for all themes. The two old theme images are replaced so they become identical in size and ball placement to the new ones.
Comment 2 Michael Catanzaro 2015-10-13 20:49:01 UTC 
Review of attachment 313217 [details] [review]:

Thanks!
Comment 3 Anders Jonsson 2015-10-13 21:10:44 UTC 
(In reply to Michael Catanzaro from comment #2)
> Review of attachment 313217 [details] [review] [review]:
> 
> Thanks!

Thanks for the review. I see that gnome-3-18 hasn't been branched yet for five-or-more, so I'll wait with pushing to master until that has been done since the patch introduces string changes.
Comment 4 Michael Catanzaro 2015-10-13 22:21:26 UTC 
Branched!
Comment 5 Anders Jonsson 2015-10-14 08:00:18 UTC 
(In reply to Michael Catanzaro from comment #4)
> Branched!

Thanks! Pushed as https://git.gnome.org/browse/five-or-more/commit/?id=efb49035613d756f0018a3cb4463dc20f4ca3dfd