After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756341 - Various code improvements and bug fixes
Various code improvements and bug fixes
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
git master
Other Linux
: Normal enhancement
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-10 13:06 UTC by Sébastien Wilmet
Modified: 2015-11-13 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sébastien Wilmet 2015-10-10 13:06:52 UTC 
See:
https://git.gnome.org/browse/devhelp/log/?h=wip/swilmet/various-code-improvements

Currently the branch contains only changes to DhSidebar.
Comment 1 Sébastien Wilmet 2015-11-13 12:42:04 UTC 
The only doubt that I have is in the commit "gedit plugin: cleanup and simplify Makefile.am":

> - Do not distribute generated files in tarballs, only devhelp.desktop.in.

So when building from a tarball, intltool is needed. Is it ok?
Comment 2 Frederic Peters 2015-11-13 12:48:01 UTC 
configure checks for intltool, so it's fine.  Just push everything you have in master and close the appropriate bugs.
Comment 3 Sébastien Wilmet 2015-11-13 13:53:55 UTC 
Pushed! Thanks for the review.