After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756330 - gnome-music crashes when clicking "back" should go to a search view
gnome-music crashes when clicking "back" should go to a search view
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.18.x
Other Linux
: Normal major
: 3.18
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-10 01:58 UTC by ritchiew
Modified: 2015-11-05 10:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix crashes when coming back from search view (1.72 KB, patch)
2015-11-05 04:01 UTC, Jordana Luft 		committed Details | Review

Description ritchiew 2015-10-10 01:58:13 UTC 
Steps to reproduce:
1. Open "Albums" view
2. Ctrl-f and search for something
3. click and open an album from the search results
4. click Back button at the top left.

Result:
gnome-music crashes with this traceback:

Traceback (most recent call last):

+ Trace 235564

  • File "/usr/lib/python3/dist-packages/gnomemusic/toolbar.py", line 144 in on_back_button_clicked 
    self._window.views[0].update_title()
  • File "/usr/lib/python3/dist-packages/gnomemusic/view.py", line 370 in update_title 
    self.header_bar.header_bar.set_title(self._escaped_title)
AttributeError: 'Albums' object has no attribute '_escaped_title' 


This appears to be caused by this change:
https://git.gnome.org/browse/gnome-music/commit/?id=be592822e9f5e628bcd3ffced3a999d3cebcc5a4
which fixed bug 754836

Reverting that change should fix the problem. But I'm missing something, because I can't really figure out what that patch was meant to fix or add.
Comment 1 Jordana Luft 2015-11-05 04:01:52 UTC 
Created attachment 314865 [details] [review]
Fix crashes when coming back from search view

https://bugzilla.gnome.org/show_bug.cgi?id=756330

It was necessary to update Toolbar.reset_header_title and
Albums._back_button_clicked to avoid a regression with
bug 746446.
Comment 2 Felipe Borges 2015-11-05 09:57:50 UTC 
Review of attachment 314865 [details] [review]:

sure.