After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756322 - dashdemux: add unit test for dashdemux
dashdemux: add unit test for dashdemux
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-09 22:06 UTC by Florin Apostol
Modified: 2015-10-29 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fake http src plugin (15.90 KB, patch)
2015-10-09 22:06 UTC, Florin Apostol
none Details | Review
unit tests for dashdemux (43.26 KB, patch)
2015-10-09 22:07 UTC, Florin Apostol
none Details | Review
fake http src plugin (15.90 KB, patch)
2015-10-13 15:57 UTC, Florin Apostol
committed Details | Review
unit tests for dashdemux (43.45 KB, patch)
2015-10-13 15:58 UTC, Florin Apostol
none Details | Review
unit tests for dashdemux (43.95 KB, patch)
2015-10-16 10:03 UTC, Florin Apostol
none Details | Review
unit tests for dashdemux (44.02 KB, patch)
2015-10-16 15:47 UTC, Florin Apostol
committed Details | Review
soup http src changed the way it handles segment stop, so we change it too (1.25 KB, patch)
2015-10-16 17:53 UTC, Florin Apostol
committed Details | Review

Description Florin Apostol 2015-10-09 22:06:07 UTC
Create an unit test for dash demux. Use a fake http src plugin to provide buffers filled with patterns for different http requests that adaptivedemux might make.
Comment 1 Florin Apostol 2015-10-09 22:06:39 UTC
Created attachment 312989 [details] [review]
fake http src plugin
Comment 2 Florin Apostol 2015-10-09 22:07:18 UTC
Created attachment 312990 [details] [review]
unit tests for dashdemux
Comment 3 Florin Apostol 2015-10-13 15:57:13 UTC
Created attachment 313204 [details] [review]
fake http src plugin

removed \n from warning messages
Comment 4 Florin Apostol 2015-10-13 15:58:09 UTC
Created attachment 313205 [details] [review]
unit tests for dashdemux

fixed a race condition in seek test
Comment 5 Florin Apostol 2015-10-16 10:03:44 UTC
Created attachment 313442 [details] [review]
unit tests for dashdemux

fixed seek test when running under gdb
    
When running under gdb, all tests will run under the same process. As a result, fake source http elements can get names like fakesouphttpsrc5.
    
Fixed the seek test to not depend on fake src http element name
Comment 6 Florin Apostol 2015-10-16 15:47:43 UTC
Created attachment 313476 [details] [review]
unit tests for dashdemux

fixed memory leak in previous patch
Comment 7 Florin Apostol 2015-10-16 17:53:09 UTC
Created attachment 313495 [details] [review]
soup http src changed the way it handles segment stop, so we change it too

updated due to changes in soup http src from https://bugzilla.gnome.org/show_bug.cgi?id=748316
Comment 8 Vincent Penquerc'h 2015-10-29 16:03:53 UTC
commit 78ce34b37f338e1da1b5a93c8e6da861a69cf5aa
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Fri Oct 16 18:36:20 2015 +0100

    tests: fixed fake soup http src plugin
    
    The soup http src changed the way it interprets the seek segment stop value.
    Previously it was inclusive, now it is not (see commit
    21c6da6764c0cd015e9f3c5eecba36e297187deb,
    bug https://bugzilla.gnome.org/show_bug.cgi?id=748316)
    
    Updated fake soup http src to also consider segment stop not inclusive.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756322

commit 0e1f5a03856eab31cd0ee2b36f9edab84307b627
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Fri Oct 9 14:10:52 2015 +0100

    adaptivedemux: tests: added unit test for adaptivedemux
    
    Created a unit test for dashdemux. It relies on a fake SOUP HTTP src plugin
    that will feed data to dashdemux. The test controls the data to be
    generated and checks the correct data was received for each expected
    stream.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756322

commit a38a9ba50d93b7339b15dafefda802ddbb21f884
Author: Alex Ashley <bugzilla@ashley-family.net>
Date:   Fri Oct 9 21:23:20 2015 +0100

    tests: added fake http src plugin
    
    Added a fake http src plugin capable of generating data buffers for a
    request of a http url. Can be used in tests to simulate http accesses.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756322