GNOME Bugzilla – Bug 756295
Baobab help "some of the folders it contains" > "some of the folders contained in"
Last modified: 2021-05-26 09:26:43 UTC
In baobab-help.master.pot two strings contain: "some of the folders it contains" But in baobab.master.pot the string says: "some of the folders contained in"
Thanks for taking the time to report. It took me a minute to understand what you are referring to. It is not related to localisation (translation), changing product to baobab. For reference, this is probably the strings the reporter is talking about: src/baobab-window.c: _tmp2_ = _ ("Could not scan folder \"%s\" or some of the folders it contains."); src/baobab-window.vala: var primary = _("Could not scan some of the folders contained in \"%s\"").printf (scanner.directory.get_parse_name ()); Looks to me like nothing is wrong and this is on purpose.
nazgul@rivendell:/git/gnome/baobab$ grep "some of the folders" po/baobab.pot msgid "Could not scan folder \"%s\" or some of the folders it contains." nazgul@rivendell:/git/gnome/baobab$ grep "some of the folders" help/C/* help/C/problem-permissions.page: <desc>I see a <gui>Could not scan /… or some of the folders it
I think this is a bug in the doc. It does not correspond to the UI message. Is that what you mean? See screen-shot.
Created attachment 312965 [details] screen-shot of the help page
Created attachment 312966 [details] [review] suggested patch
I dont like the "… or" part so much. I read it like the "or" is part of the string. Also the start of "some of the folders it contains" is missing. So maybe like this: "Could not scan folder … / Could not scan some of the folders contained in …" Or: "Could not scan folder …/Could not scan some of the folders contained in …"
Or maybe no space before "…" like this: "Could not scan folder… / Could not scan some of the folders contained in…" Or: "Could not scan folder…/Could not scan some of the folders contained in…"
Comment on attachment 312966 [details] [review] suggested patch The UI messages do not correspond to the user doc changes, hence setting "needs-rework" status: ./src/baobab-window.vala: var primary = _("Could not scan some of the folders contained in “%s”").printf (scanner.directory.get_parse_name ()); ./src/baobab-window.vala: var primary = _("Could not scan folder “%s”").printf (scanner.directory.get_parse_name ());
There is a difference between UI messages and user doc quotation. That is what my patch tries to amend. I do not understand why my patch is considered as "needs work". After applying it the message and quotation match.
Comment on attachment 312966 [details] [review] suggested patch I see. As I don't seem to understand enough what this is about, resetting patch status.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Baobab, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/baobab/-/issues/ Thank you for your understanding and your help.