After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756282 - [PLUGIN-MOVE] Move opus to -base
[PLUGIN-MOVE] Move opus to -base
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.7.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 757152
Blocks:
 
 
Reported: 2015-10-09 09:55 UTC by Tim-Philipp Müller
Modified: 2016-03-11 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
opusenc: remove deprecated "cbr", "audio", and "constrained-vbr" properties (5.59 KB, patch)
2016-02-26 00:56 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2015-10-09 09:55:35 UTC
I would like to move opus to either -good or -base in this cycle.

This bug is to track anything that's left to do before this happens.

If I remember correctly, multichannel support needs to be fixed up or implemented before we can move it, in case we need additional/changed caps signalling for that case.
Comment 1 Sebastian Dröge (slomo) 2015-10-10 08:30:40 UTC
Yes, we should figure out multichannel stuff before to make sure we don't need to change caps because of that.
Comment 2 Sebastian Dröge (slomo) 2015-11-03 18:41:59 UTC
IMHO good to go now. Except for: opusparse should go to audioparsers (and lose its libopus dependency), rtpopus* should go to the rtp plugin (after losing its libopus dependency).
Comment 3 Tim-Philipp Müller 2016-02-26 00:33:25 UTC
opusenc has some deprecated properties:

 cbr             : Constant bit rate (DEPRECATED: use bitrate-type)

 constrained-vbr : Constrained VBR (DEPRECATED: use bitrate-type)

Maybe we should remove those ?
Comment 4 Tim-Philipp Müller 2016-02-26 00:56:09 UTC
Created attachment 322430 [details] [review]
opusenc: remove deprecated "cbr", "audio", and "constrained-vbr" properties
Comment 5 Sebastian Dröge (slomo) 2016-02-26 06:51:32 UTC
Comment on attachment 322430 [details] [review]
opusenc: remove deprecated "cbr", "audio", and "constrained-vbr" properties

Yes, now or never :)
Comment 6 Tim-Philipp Müller 2016-02-26 06:56:55 UTC
Comment on attachment 322430 [details] [review]
opusenc: remove deprecated "cbr", "audio", and "constrained-vbr" properties

Let's make it now then!
Comment 7 Tim-Philipp Müller 2016-03-03 17:46:10 UTC
I think this is resolved for most purposes.

opusenc/dec are now in -base, rtp payloader/depayloader in -good.

opusparse is still in -bad and can be moved in the next cycle, or not. It's not autoplugged and not particularly important really.