After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756212 - Build race in plugins/common
Build race in plugins/common
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-07 23:57 UTC by Michael Catanzaro
Modified: 2015-10-08 14:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
common: Ensure enums are generated before sources are built (1.01 KB, patch)
2015-10-08 00:03 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2015-10-07 23:57:56 UTC
The sources under plugins/common need to depend on the enum generation.

gsd-device-manager.c: In function 'gsd_device_class_init':
gsd-device-manager.c:208:13: error: 'GSD_TYPE_DEVICE_TYPE' undeclared (first use in this function)
             GSD_TYPE_DEVICE_TYPE, 0,
             ^
Comment 1 Michael Catanzaro 2015-10-08 00:03:06 UTC
Created attachment 312864 [details] [review]
common: Ensure enums are generated before sources are built

Probably fixes this build race:

gsd-device-manager.c: In function 'gsd_device_class_init':
gsd-device-manager.c:208:13: error: 'GSD_TYPE_DEVICE_TYPE' undeclared
(first use in this function)
             GSD_TYPE_DEVICE_TYPE, 0,
             ^
Comment 2 Bastien Nocera 2015-10-08 10:58:45 UTC
Review of attachment 312864 [details] [review]:

Sure.
Comment 3 Michael Catanzaro 2015-10-08 14:44:58 UTC
Attachment 312864 [details] pushed as acc58ea - common: Ensure enums are generated before sources are built