After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756209 - adaptivedemux: adaptive demux hangs if src element cannot be started
adaptivedemux: adaptive demux hangs if src element cannot be started
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-07 22:20 UTC by Florin Apostol
Modified: 2015-10-30 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.40 KB, patch)
2015-10-07 22:22 UTC, Florin Apostol 		none Details | Review
proposed patch (1.16 KB, patch)
2015-10-30 12:06 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2015-10-07 22:20:13 UTC 
gst_adaptive_demux_stream_download_uri will try to start the src element by calling gst_element_sync_state_with_parent. But the return code is not checked. If the src element does not start, the adaptive demux will wait forever for the eos event.
Comment 1 Florin Apostol 2015-10-07 22:22:13 UTC 
Created attachment 312860 [details] [review]
proposed patch
Comment 2 Vincent Penquerc'h 2015-10-30 11:56:17 UTC 
It looks like the manifest lock should be reacquired when returning here. The patch does not apply cleanly to my state, but at least here, this function is called with the manifest lock, and can temporarily release it.

Since the patch doesn't apply, maybe it's meant to apply after another one that removes this "called with manifest lock" state ?
Comment 3 Florin Apostol 2015-10-30 12:06:28 UTC 
Created attachment 314465 [details] [review]
proposed patch

updated patch.

This ticket was raised before https://bugzilla.gnome.org/show_bug.cgi?id=755169 which made changes in this area.
Comment 4 Florin Apostol 2015-10-30 12:07:56 UTC 
I meant "ticket raised before 755169 fixes were merged"
Comment 5 Vincent Penquerc'h 2015-10-30 12:23:53 UTC 
Thanks.

commit ef466b46d3353aa56b25663b74021e37c8bbcc82
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Wed Oct 7 23:20:51 2015 +0100

    adaptivedemux: return error if src element cannot start
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756209