GNOME Bugzilla – Bug 756194
xadapter: Avoid a crash when Xkl doesn't know the real xkb groups
Last modified: 2015-10-12 23:55:01 UTC
Reported in https://bugzilla.redhat.com/show_bug.cgi?id=1228935
Created attachment 312836 [details] [review] xadapter: Avoid a crash when Xkl doesn't know the real xkb groups Xkl.ConfigRec gets its layouts and variants from the _XKB_RULES_NAMES root window property which isn't specified anywhere and in fact doesn't get set under Xwayland. The group index though is accurate which means that we might end up trying to access an invalid index on the layouts or variants array and crashing. Avoid this by just lying to the caller since we can't obtain the real layout/variant names in that case. Since this only happens under Xwayland and in that case the only consumer of this API is gnome-shell which ends up not using the names, this should be safe.
Review of attachment 312836 [details] [review]: That makes sense. Thanks.
Attachment 312836 [details] pushed as 2f98ddd - xadapter: Avoid a crash when Xkl doesn't know the real xkb groups