After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756192 - colour button has no way to set its dialogue to editor mode
colour button has no way to set its dialogue to editor mode
Product: gtk+
Classification: Platform
Component: Widget: GtkColorChooser
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
Depends on:
Reported: 2015-10-07 13:47 UTC by Christian Persch
Modified: 2016-01-27 02:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description Christian Persch 2015-10-07 13:47:07 UTC
GtkColorButton is used in gnome-terminal to edit the colour palette. However, by default the colour button pops up its GtkColorChooserDialog in palette mode, which is not what we want, since it means that to actually choose a colour the user has to again click on the "+" button.

Now GtkColorChooserDialog has a property 'show-editor' which does what we want, but a) it cannot be set from GtkColorButton, and b) GtkColorChooserDialog always unsets the property on ::map. 

To fix the problem, GtkColorButton should gain a "show-editor" property and forward it to its GtkColorChooserDialog.

(In the meantime, I will work around this in gnome-terminal with a gross hack.)
Comment 1 Allan Day 2015-10-16 11:53:32 UTC
Are there any other cases where this behaviour would be needed?
Comment 2 Christian Persch 2015-10-16 19:20:06 UTC
I think that _most_ use cases of a colour button would want this direct access to setting a colour, and only few use cases would call for selecting the colour from a limited palette.
Comment 3 Matthias Clasen 2016-01-23 17:53:10 UTC
See bug 761005 for a use case
Comment 4 Matthias Clasen 2016-01-24 18:17:27 UTC
A use case for using the editor standlone, I should say, not for having the color button pop up the editor instead of the palette.
Comment 5 Matthias Clasen 2016-01-27 02:30:15 UTC
I've added a GtkColorButton::show-editor property for this now.