After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756146 - Don't negate Application.isBooks when not necessary
Don't negate Application.isBooks when not necessary
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.17.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-06 21:54 UTC by Alessandro Bono
Modified: 2015-10-12 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
application, embed, search: Don't negate Application.isBook (8.46 KB, patch)
2015-10-06 21:54 UTC, Alessandro Bono 		none Details | Review
application, embed, search: Don't negate Application.isBooks (8.46 KB, patch)
2015-10-06 21:55 UTC, Alessandro Bono 		committed Details | Review

Description Alessandro Bono 2015-10-06 21:54:13 UTC 
For exemple, when we have an if-then-else statement
Comment 1 Alessandro Bono 2015-10-06 21:54:54 UTC 
Created attachment 312769 [details] [review]
application, embed, search: Don't negate Application.isBook
Comment 2 Alessandro Bono 2015-10-06 21:55:59 UTC 
Created attachment 312770 [details] [review]
application, embed, search: Don't negate Application.isBooks
Comment 3 Debarshi Ray 2015-10-12 17:53:30 UTC 
Review of attachment 312770 [details] [review]:

Thanks, looks good to me.