GNOME Bugzilla – Bug 756133
Improve albums UI
Last modified: 2018-01-23 09:49:20 UTC
Alessandro overhauled gnome-documents' collections dialog in 3.18. See bug 726450 Let's do the same for gnome-photos for 3.20.
Design: https://wiki.gnome.org//Design/OS/Collections
Created attachment 312752 [details] [review] view-model: Stop listening to info-updated when an item is removed
*** Bug 740435 has been marked as a duplicate of this bug. ***
Continuing to listen info-updated from removed items can actually lead to a crash. eg., in this case, I think an item was removed, then an info-updated was received from the thumbnailing operation (which might have failed), which led to ViewModel's row being updated, but PreviewModel needs an item to be present in the ItemManager to figure out the visibility:
+ Trace 235575
Thread 1 (Thread 0x7fe5d55cca40 (LWP 6084))
Dowstream crash report: https://bugzilla.redhat.com/show_bug.cgi?id=1159321
Created attachment 313188 [details] [review] view-model: Stop listening to info-updated when an item is removed
The current plan is not to implement the same UX as Documents, but something different: https://dl.dropboxusercontent.com/u/5031519/photos/photos-albums-wires.png
I was going to report on this bug: the current UI to add a photo to an album – particularly to a new one – really confused me. The fact that "Add" doesn't add the photos but an album but add a new album confused me, also I can't find another way to cancel the changes than by pressing Escape. The mockups are lovely.
Latest mockups can be found here: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/photos/wires-albums.png Also, updating the bug title to reflect that this isn't just about improving album creation.
*** Bug 785052 has been marked as a duplicate of this bug. ***
(In reply to Allan Day from comment #9) > Latest mockups can be found here: > https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/ > photos/wires-albums.png > > Also, updating the bug title to reflect that this isn't just about improving > album creation. Designers - Ping, Can you please help me re-validate the link if you think the mockups is still good for implementation?
(In reply to Umang Jain from comment #11) ... > Designers - Ping, Can you please help me re-validate the link if you think > the mockups is still good for implementation? The mockups still look valid to me. It would be great to make some progress on this!
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-photos/issues/32.