After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756133 - Improve albums UI
Improve albums UI
Status: RESOLVED OBSOLETE
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
: 740435 785052 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-10-06 17:37 UTC by Debarshi Ray
Modified: 2018-01-23 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
view-model: Stop listening to info-updated when an item is removed (4.53 KB, patch)
2015-10-06 17:41 UTC, Debarshi Ray
none Details | Review
view-model: Stop listening to info-updated when an item is removed (6.26 KB, patch)
2015-10-13 13:56 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2015-10-06 17:37:21 UTC
Alessandro overhauled gnome-documents' collections dialog in 3.18. See bug 726450

Let's do the same for gnome-photos for 3.20.
Comment 1 Debarshi Ray 2015-10-06 17:38:13 UTC
Design: https://wiki.gnome.org//Design/OS/Collections
Comment 2 Debarshi Ray 2015-10-06 17:41:03 UTC
Created attachment 312752 [details] [review]
view-model: Stop listening to info-updated when an item is removed
Comment 3 Debarshi Ray 2015-10-13 08:32:24 UTC
*** Bug 740435 has been marked as a duplicate of this bug. ***
Comment 4 Debarshi Ray 2015-10-13 11:08:50 UTC
Continuing to listen info-updated from removed items can actually lead to a crash. eg., in this case, I think an item was removed, then an info-updated was received from the thumbnailing operation (which might have failed), which led to ViewModel's row being updated, but PreviewModel needs an item to be present in the ItemManager to figure out the visibility:

Thread 1 (Thread 0x7fe5d55cca40 (LWP 6084))

  • #0 photos_base_item_get_identifier
    at photos-base-item.c line 1176
  • #1 photos_preview_model_visible
    at photos-preview-model.c line 56
  • #2 gtk_tree_model_filter_real_visible
    at gtktreemodelfilter.c line 1250
  • #3 gtk_tree_model_filter_visible
    at gtktreemodelfilter.c line 1280
  • #4 gtk_tree_model_filter_row_changed
    at gtktreemodelfilter.c line 2031
  • #5 g_closure_invoke
    at gclosure.c line 768
  • #6 signal_emit_unlocked_R
    at gsignal.c line 3553
  • #7 g_signal_emit_valist
    at gsignal.c line 3309
  • #8 g_signal_emit
    at gsignal.c line 3365
  • #9 gtk_tree_model_row_changed
    at gtktreemodel.c line 1832
  • #10 gtk_list_store_sort_iter_changed
    at gtkliststore.c line 2016
  • #11 gtk_list_store_set_valist
    at gtkliststore.c line 1143
  • #12 gtk_list_store_set
    at gtkliststore.c line 1179
  • #13 photos_view_model_info_set
    at photos-view-model.c line 81
  • #14 photos_view_model_add_item
    at photos-view-model.c line 143
  • #15 photos_view_model_info_updated
    at photos-view-model.c line 276
  • #16 g_closure_invoke
    at gclosure.c line 768
  • #17 signal_emit_unlocked_R
    at gsignal.c line 3553
  • #18 g_signal_emit_valist
    at gsignal.c line 3309
  • #19 g_signal_emit
    at gsignal.c line 3365
  • #20 photos_base_item_check_effects_and_update_info
    at photos-base-item.c line 236
  • #21 photos_base_item_set_original_icon
    at photos-base-item.c line 256
  • #22 photos_base_item_refresh_thumb_path_pixbuf
    at photos-base-item.c line 457
  • #23 g_task_return_now
    at gtask.c line 1077
  • #24 complete_in_idle_cb
    at gtask.c line 1086

Comment 5 Debarshi Ray 2015-10-13 11:09:16 UTC
Dowstream crash report: https://bugzilla.redhat.com/show_bug.cgi?id=1159321
Comment 6 Debarshi Ray 2015-10-13 13:56:05 UTC
Created attachment 313188 [details] [review]
view-model: Stop listening to info-updated when an item is removed
Comment 7 Debarshi Ray 2015-12-11 17:24:21 UTC
The current plan is not to implement the same UX as Documents, but something different: https://dl.dropboxusercontent.com/u/5031519/photos/photos-albums-wires.png
Comment 8 Adrien Plazas 2016-01-10 14:15:01 UTC
I was going to report on this bug: the current UI to add a photo to an album – particularly to a new one – really confused me. The fact that "Add" doesn't add the photos but an album but add a new album confused me, also I can't find another way to cancel the changes than by pressing Escape.

The mockups are lovely.
Comment 9 Allan Day 2016-03-27 17:23:17 UTC
Latest mockups can be found here: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/photos/wires-albums.png

Also, updating the bug title to reflect that this isn't just about improving album creation.
Comment 10 Debarshi Ray 2017-07-18 09:57:38 UTC
*** Bug 785052 has been marked as a duplicate of this bug. ***
Comment 11 Umang Jain 2018-01-05 15:10:10 UTC
(In reply to Allan Day from comment #9)
> Latest mockups can be found here:
> https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/
> photos/wires-albums.png
> 
> Also, updating the bug title to reflect that this isn't just about improving
> album creation.

Designers - Ping, Can you please help me re-validate the link if you think the mockups is still good for implementation?
Comment 12 Allan Day 2018-01-05 17:37:48 UTC
(In reply to Umang Jain from comment #11)
...
> Designers - Ping, Can you please help me re-validate the link if you think
> the mockups is still good for implementation?

The mockups still look valid to me. It would be great to make some progress on this!
Comment 13 GNOME Infrastructure Team 2018-01-23 09:49:20 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-photos/issues/32.