After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756098 - Should use g_icon_serialize() to pass icons to shell in search provider
Should use g_icon_serialize() to pass icons to shell in search provider
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-05 21:12 UTC by David King
Modified: 2015-10-07 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use g_icon_serialize() (2.93 KB, patch)
2015-10-05 21:14 UTC, David King 		committed Details | Review
remove obsolete code (958 bytes, patch)
2015-10-05 21:14 UTC, David King 		committed Details | Review

Description David King 2015-10-05 21:12:43 UTC 
While investigating a downstream crash report from the gnome-contacts search provider, I found that the provider was passing the avatar icons to the shell using g_icon_to_string(). The new way is to use g_icon_serialize() instead. This avoids the crash (which seems to be caused by a Vala bug with the g_variant_new_from_data() binding, described in bug 756090) and simplifies the code.
Comment 1 David King 2015-10-05 21:14:09 UTC 
Created attachment 312692 [details] [review]
use g_icon_serialize()
Comment 2 David King 2015-10-05 21:14:40 UTC 
Created attachment 312693 [details] [review]
remove obsolete code
Comment 3 Erick Perez Castellanos 2015-10-07 14:13:52 UTC 
Review of attachment 312692 [details] [review]:

LGTM, push
Comment 4 Erick Perez Castellanos 2015-10-07 14:14:41 UTC 
Review of attachment 312693 [details] [review]:

LGTM
Comment 5 Erick Perez Castellanos 2015-10-07 14:15:09 UTC 
(In reply to David King from comment #0)
> While investigating a downstream crash report from the gnome-contacts search
> provider, I found that the provider was passing the avatar icons to the
> shell using g_icon_to_string(). The new way is to use g_icon_serialize()
> instead. This avoids the crash (which seems to be caused by a Vala bug with
> the g_variant_new_from_data() binding, described in bug 756090) and
> simplifies the code.

Thxs for your work on this.
Comment 6 David King 2015-10-07 15:08:18 UTC 
Review of attachment 312692 [details] [review]:

Pushed to master as commit 97125eb29dba7cf1f9c844da1f3e3531c31de5cd.
Comment 7 David King 2015-10-07 15:08:44 UTC 
Review of attachment 312693 [details] [review]:

Pushed to master as commit 092bb89b789f113a3aeee03c268da08fbec3ede0.
Comment 8 David King 2015-10-07 15:11:26 UTC 
Also pushed to gnome-3-16. Thanks for the reviews!