After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756088 - giscanner.message: Don't print node as the default context
giscanner.message: Don't print node as the default context
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-05 18:46 UTC by Mikhail Zabaluev
Modified: 2015-10-06 06:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
giscanner.message: Don't print node as the default context (1.01 KB, patch)
2015-10-05 18:46 UTC, Mikhail Zabaluev 		accepted-commit_now Details | Review

Description Mikhail Zabaluev 2015-10-05 18:46:19 UTC 
Node is always present in the output of .log_node(), so printing it
another time as context just adds noise.
Comment 1 Mikhail Zabaluev 2015-10-05 18:46:23 UTC 
Created attachment 312688 [details] [review]
giscanner.message: Don't print node as the default context

Node is always present in the output of .log_node(), so printing it
another time as context just adds noise.
Comment 2 Colin Walters 2015-10-05 20:46:59 UTC 
Review of attachment 312688 [details] [review]:

OK, I think I see an example where this is better.  Hope we're not losing context from somewhere though.
Comment 4 Mikhail Zabaluev 2015-10-06 06:40:36 UTC 
(In reply to Colin Walters from comment #2)
> Review of attachment 312688 [details] [review] [review]:
> 
> OK, I think I see an example where this is better.  Hope we're not losing
> context from somewhere though.

The way I understand it works is, there's either positions= and then the context is expected to be passed as well, or then the positions and context are taken from the AST node. If there were no positions set on the node, the default context repeated the node printout, but this time in repr.