After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756077 - testutils: remove internal ABI comment
testutils: remove internal ABI comment
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-10-05 11:12 UTC by Marc-Andre Lureau
Modified: 2015-10-05 13:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
testutils: remove internal ABI comment (1.96 KB, patch)
2015-10-05 11:12 UTC, Marc-Andre Lureau
accepted-commit_now Details | Review

Description Marc-Andre Lureau 2015-10-05 11:12:18 UTC
Some testutils external symbols are marked semi-internals, other
internals. It is not obvious what guarantees these symbols provide.
However, tests are now installable, and require the ABI stability
that glib provides for the rest of the symbols.

In my case, I would like to introduce g_assert* compat code for older
glib versions, and be able to use the so-called "internal" ABI.

I propose this change to the headers comments to explain the stability
guarantees. Removing the "internal" = you must not use this, in favor
of semi-internal = this is not documented.
Comment 1 Marc-Andre Lureau 2015-10-05 11:12:26 UTC
Created attachment 312671 [details] [review]
testutils: remove internal ABI comment
Comment 2 Colin Walters 2015-10-05 12:50:23 UTC
Review of attachment 312671 [details] [review]:

OK.